From: Stephen Hemminger <shemminger@vyatta•com>
To: Cong Wang <amwang@redhat•com>
Cc: netdev@vger•kernel.org, bridge@lists•linux-foundation.org,
Herbert Xu <herbert@gondor•hengli.com.au>,
Jesper Dangaard Brouer <brouer@redhat•com>,
Thomas Graf <tgraf@suug•ch>,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH net-next v2] bridge: export multicast database via netlink
Date: Tue, 4 Dec 2012 08:53:20 -0800 [thread overview]
Message-ID: <20121204085320.3e08986a@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1354539824-7898-1-git-send-email-amwang@redhat.com>
On Mon, 3 Dec 2012 21:03:43 +0800
Cong Wang <amwang@redhat•com> wrote:
> V2: drop patch 1/2, export ifindex directly
> Redesign netlink attributes
> Improve netlink seq check
> Handle IPv6 addr as well
>
> TODO: remove debugging printk's
>
> This patch exports bridge multicast database via netlink
> message type RTM_GETMDB. Similar to fdb, but currently bridge-specific.
> We may need to support modify multicast database too (RTM_{ADD,DEL}MDB).
>
> Cc: Herbert Xu <herbert@gondor•apana.org.au>
> Cc: Stephen Hemminger <shemminger@vyatta•com>
> Cc: "David S. Miller" <davem@davemloft•net>
> Cc: Thomas Graf <tgraf@suug•ch>
> Cc: Jesper Dangaard Brouer <brouer@redhat•com>
> Signed-off-by: Cong Wang <amwang@redhat•com>
>
Minor nit reported by checkpatch was the messages should be using the api
which provides the most info in the log to identify.
WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
#190: FILE: net/bridge/br_mdb.c:28:
+ printk(KERN_INFO "no router on bridge\n")
There is a set of macro's already for use in bridging code:
br_info(br, "no router on bridge\n");
next prev parent reply other threads:[~2012-12-04 16:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 13:03 [PATCH net-next v2] bridge: export multicast database via netlink Cong Wang
2012-12-03 13:03 ` [PATCH iproute2 v2] Add mdb command to bridge Cong Wang
2012-12-04 16:53 ` Stephen Hemminger [this message]
2012-12-05 2:08 ` [PATCH net-next v2] bridge: export multicast database via netlink Cong Wang
2012-12-04 18:25 ` David Miller
2012-12-05 2:07 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121204085320.3e08986a@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta$(echo .)com \
--cc=amwang@redhat$(echo .)com \
--cc=bridge@lists$(echo .)linux-foundation.org \
--cc=brouer@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=herbert@gondor$(echo .)hengli.com.au \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tgraf@suug$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox