From: Steffen Klassert <steffen.klassert@secunet•com>
To: Cong Wang <amwang@redhat•com>
Cc: netdev@vger•kernel.org, Herbert Xu <herbert@gondor•hengli.com.au>,
"David S. Miller" <davem@davemloft•net>,
Eric Paris <eparis@parisplace•org>,
linux-security-module@secunet•com
Subject: Re: [Patch net-next] xfrm: add missing xfrm message types to selinux perm table
Date: Wed, 5 Dec 2012 09:14:06 +0100 [thread overview]
Message-ID: <20121205081406.GB18940@secunet.com> (raw)
In-Reply-To: <1354693368-19494-1-git-send-email-amwang@redhat.com>
Ccing Eric Paris and linux-security-module.
On Wed, Dec 05, 2012 at 03:42:48PM +0800, Cong Wang wrote:
> SElinux perm table is not up-to-date.
>
> Cc: Steffen Klassert <steffen.klassert@secunet•com>
> Cc: Herbert Xu <herbert@gondor•apana.org.au>
> Cc: "David S. Miller" <davem@davemloft•net>
> Signed-off-by: Cong Wang <amwang@redhat•com>
>
> ---
> diff --git a/security/selinux/nlmsgtab.c b/security/selinux/nlmsgtab.c
> index d309e7f..cc191bc 100644
> --- a/security/selinux/nlmsgtab.c
> +++ b/security/selinux/nlmsgtab.c
> @@ -93,6 +93,13 @@ static struct nlmsg_perm nlmsg_xfrm_perms[] =
> { XFRM_MSG_FLUSHPOLICY, NETLINK_XFRM_SOCKET__NLMSG_WRITE },
> { XFRM_MSG_NEWAE, NETLINK_XFRM_SOCKET__NLMSG_WRITE },
> { XFRM_MSG_GETAE, NETLINK_XFRM_SOCKET__NLMSG_READ },
> + { XFRM_MSG_REPORT, NETLINK_XFRM_SOCKET__NLMSG_READ },
> + { XFRM_MSG_MIGRATE, NETLINK_XFRM_SOCKET__NLMSG_WRITE },
> + { XFRM_MSG_NEWSADINFO, NETLINK_XFRM_SOCKET__NLMSG_WRITE },
> + { XFRM_MSG_GETSADINFO, NETLINK_XFRM_SOCKET__NLMSG_READ },
> + { XFRM_MSG_NEWSPDINFO, NETLINK_XFRM_SOCKET__NLMSG_WRITE },
> + { XFRM_MSG_GETSPDINFO, NETLINK_XFRM_SOCKET__NLMSG_READ },
> + { XFRM_MSG_MAPPING, NETLINK_XFRM_SOCKET__NLMSG_READ },
> };
>
> static struct nlmsg_perm nlmsg_audit_perms[] =
I'm not the maintainer of the file which this patch changes,
but I could take it into the ipsec-next tree if the selinux
people are fine with that.
next prev parent reply other threads:[~2012-12-05 8:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 7:42 [Patch net-next] xfrm: add missing xfrm message types to selinux perm table Cong Wang
2012-12-05 8:14 ` Steffen Klassert [this message]
[not found] <1354599571-6181-1-git-send-email-amwang@redhat.com>
2012-12-04 18:02 ` David Miller
2012-12-05 5:41 ` Steffen Klassert
2012-12-05 6:56 ` Cong Wang
2012-12-05 7:39 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121205081406.GB18940@secunet.com \
--to=steffen.klassert@secunet$(echo .)com \
--cc=amwang@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eparis@parisplace$(echo .)org \
--cc=herbert@gondor$(echo .)hengli.com.au \
--cc=linux-security-module@secunet$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox