From: Stephen Hemminger <shemminger@vyatta•com>
To: Nicolas Dichtel <nicolas.dichtel@6wind•com>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH iproute2] ip: use rtnelink to manage mroute
Date: Wed, 12 Dec 2012 10:26:17 -0800 [thread overview]
Message-ID: <20121212102617.0a3249e4@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1355304728-4944-1-git-send-email-nicolas.dichtel@6wind.com>
On Wed, 12 Dec 2012 10:32:08 +0100
Nicolas Dichtel <nicolas.dichtel@6wind•com> wrote:
> mroute was using /proc/net/ip_mr_[vif|cache] to display mroute entries. Hence,
> only RT_TABLE_DEFAULT was displayed and only IPv4.
> With rtnetlink, it is possible to display all tables for IPv4 and IPv6. The output
> format is kept. Also, like before the patch, statistics are displayed when user specify
> the '-s' argument.
>
> The patch also adds the support of 'ip monitor mroute', which is now possible.
>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind•com>
> ---
The functionality is fine, and if you clean it up I will accept it.
Patch does not apply cleanly against current iproute2 git.
Also, it causes several compiler warnings.
ipmonitor.c: In function ‘accept_msg’:
ipmonitor.c:50:20: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘long unsigned int’ [-Wformat]
ipmroute.c: In function ‘print_mroute’:
ipmroute.c:165:4: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘__u64’ [-Wformat]
ipmroute.c:165:4: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘__u64’ [-Wformat]
ipmroute.c:168:5: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘__u64’ [-Wformat]
next prev parent reply other threads:[~2012-12-12 18:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 9:32 [PATCH iproute2] ip: use rtnelink to manage mroute Nicolas Dichtel
2012-12-12 18:26 ` Stephen Hemminger [this message]
2012-12-13 9:16 ` [PATCH iproute2 v2] " Nicolas Dichtel
2012-12-14 18:10 ` Stephen Hemminger
2012-12-17 8:41 ` Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121212102617.0a3249e4@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.dichtel@6wind$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox