From: Stephen Hemminger <shemminger@vyatta•com>
To: Jiri Pirko <jiri@resnulli•us>
Cc: Flavio Leitner <fbl@redhat•com>,
John Fastabend <john.fastabend@gmail•com>,
netdev@vger•kernel.org, davem@davemloft•net, edumazet@google•com,
bhutchings@solarflare•com, mirqus@gmail•com,
greearb@candelatech•com
Subject: Re: [patch net-next 0/4] net: allow to change carrier from userspace
Date: Fri, 14 Dec 2012 08:12:01 -0800 [thread overview]
Message-ID: <20121214081201.1205b613@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <20121214144134.GA1652@minipsycho.brq.redhat.com>
On Fri, 14 Dec 2012 15:41:34 +0100
Jiri Pirko <jiri@resnulli•us> wrote:
> Thu, Dec 13, 2012 at 07:20:51PM CET, shemminger@vyatta•com wrote:
> >On Thu, 13 Dec 2012 16:17:33 -0200
> >Flavio Leitner <fbl@redhat•com> wrote:
> >
> >> On Thu, 13 Dec 2012 10:09:33 -0800
> >> Stephen Hemminger <shemminger@vyatta•com> wrote:
> >>
> >> > On Thu, 13 Dec 2012 15:54:23 -0200
> >> > Flavio Leitner <fbl@redhat•com> wrote:
> >> >
> >> > > I am saying this because people are used to and there are scripts out
> >> > > there using something like:
> >> > > # ethtool <iface> | grep 'Link'
> >> > > to react an interface failure.
> >> >
> >> > Then the script is broken. It is asking about hardware state.
> >>
> >> I was talking about the team master interface, so it makes sense
> >> to check its 'hardware' state. Just think on 'bond0' interface
> >> with no slaves. It should report Link detected: no.
> >>
> >> See bond_release(), what happens if bond->slave_cnt == 0, for instance.
> >>
> >
> >I was thinking more that ethtool operation for reporting link on
> >the team device should use the proper check rather than just using netif_carrier_ok(),
> >the team ethtool operation for get_link should be check IFF_RUNNING flag
> >in dev->flags which is controlled by operstate transistions.
>
> I admit I'm bit confused now.
>
> For example in bridge code:
> in br_add_if() - netif_carrier_ok() is checked and by the value it is
> decided if br_stp_enable_port() is called or not. Wouldn't it make more
> sense to check IFF_RUNNING (or netif_oper_up()) here?
>
> The reason I'm asing is that if team device is in bridge, carrier is
> always ON and I'm fiddling with IF_OPER_UP and IF_OPER_DORMANT from
> userspace, in current code, bridge wouldn't know the difference...
>
> There are more exmaples of similar usage of netif_carrier_ok() in
> bridge (called on ports), bonding (called on slaves), team code (called on ports).
Yes the bridge should be fixed to work with user controlled devices.
next prev parent reply other threads:[~2012-12-14 16:13 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 10:58 [patch net-next 0/4] net: allow to change carrier from userspace Jiri Pirko
2012-12-12 10:58 ` [patch net-next 1/4] net: add change_carrier netdev op Jiri Pirko
2012-12-12 10:58 ` [patch net-next 2/4] net: allow to change carrier via sysfs Jiri Pirko
2012-12-12 10:58 ` [patch net-next 3/4] rtnl: expose carrier value with possibility to set it Jiri Pirko
2012-12-12 10:58 ` [patch net-next 4/4] dummy: implement carrier change Jiri Pirko
2012-12-12 16:15 ` [patch net-next 0/4] net: allow to change carrier from userspace Stephen Hemminger
2012-12-12 17:05 ` Jiri Pirko
2012-12-12 17:27 ` Stephen Hemminger
2012-12-12 18:10 ` Jiri Pirko
2012-12-12 18:12 ` Stephen Hemminger
2012-12-12 18:25 ` Jiri Pirko
2012-12-12 18:36 ` Stephen Hemminger
2012-12-12 18:49 ` Jiri Pirko
2012-12-12 18:54 ` Stephen Hemminger
2012-12-12 19:06 ` Jiri Pirko
2012-12-12 19:34 ` Stephen Hemminger
2012-12-13 16:17 ` Jiri Pirko
2012-12-13 17:15 ` John Fastabend
2012-12-13 17:54 ` Flavio Leitner
2012-12-13 18:09 ` Stephen Hemminger
2012-12-13 18:17 ` Flavio Leitner
2012-12-13 18:20 ` Stephen Hemminger
2012-12-13 18:33 ` Dan Williams
2012-12-13 19:09 ` John Fastabend
2012-12-13 21:32 ` Jiri Pirko
2012-12-14 14:41 ` Jiri Pirko
2012-12-14 16:12 ` Stephen Hemminger [this message]
2012-12-14 16:35 ` Jiri Pirko
2012-12-14 16:59 ` Stephen Hemminger
2012-12-14 17:13 ` Jiri Pirko
2012-12-14 17:23 ` Stephen Hemminger
2012-12-14 17:35 ` Jiri Pirko
2012-12-16 10:54 ` Jiri Pirko
2012-12-18 6:49 ` Stephen Hemminger
2012-12-18 9:31 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121214081201.1205b613@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta$(echo .)com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=fbl@redhat$(echo .)com \
--cc=greearb@candelatech$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=john.fastabend@gmail$(echo .)com \
--cc=mirqus@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox