public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Jiri Pirko <jiri@resnulli•us>
To: Ben Hutchings <bhutchings@solarflare•com>
Cc: netdev@vger•kernel.org
Subject: Re: perm_addr get
Date: Fri, 21 Dec 2012 14:25:00 +0100	[thread overview]
Message-ID: <20121221132500.GC2040@minipsycho.orion> (raw)
In-Reply-To: <1356095395.7055.34.camel@deadeye.wl.decadent.org.uk>

Fri, Dec 21, 2012 at 02:09:55PM CET, bhutchings@solarflare•com wrote:
>On Fri, 2012-12-21 at 14:01 +0100, Jiri Pirko wrote:
>> Hi all.
>> 
>> From what I understand dev->perm_addr is set only in case the hw has
>> permanent hw address somewhere written (for example EPROM).
>> 
>> So when I query device which does not have perm_addr set I get:
>> 
>> testt1:~$ ethtool -P team0
>> Permanent address: 00:00:00:00:00:00
>> 
>> Is this the correct behaviour? Wouldn't it be more correct if
>> ethtool_get_perm_addr() fails with -ENOENT for something like that?
>
>I don't think we should change the implementation now, as someone might
>depend on it.  It's trivial to distinguish this not-a-permanent-address
>case.  However the ethtool command output could be improved.

Well, not change it even if it is not correct? And by "trivial to distinguish"
you mean 00:00:00:00:00:00 ~ device has no permanent address?
But in some cases (like vxge, mac80211) it's possible to see 00:00:00:00:00:00
by ethtool -P even though the device has permanent address (set later on, after
register_netdev call).

I think that ethtool_get_perm_addr should return:
-ENOENT if dev has no perm addr
-EAGAIN if dev perm addr hasn't been obtained yet
0 (and addr) in other cases
	
And how exactly should be the ethtool output improved?

Thanks

Jiri

>
>Ben.
>
>-- 
>Ben Hutchings, Staff Engineer, Solarflare
>Not speaking for my employer; that's the marketing department's job.
>They asked us to note that Solarflare product names are trademarked.
>

next prev parent reply	other threads:[~2012-12-21 13:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-21 13:01 perm_addr get Jiri Pirko
2012-12-21 13:09 ` Ben Hutchings
2012-12-21 13:25   ` Jiri Pirko [this message]
2012-12-21 14:40     ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121221132500.GC2040@minipsycho.orion \
    --to=jiri@resnulli$(echo .)us \
    --cc=bhutchings@solarflare$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox