Subject: Re: [PATCH 19/29] batman-adv: fix random jitter calculation

From: Antonio Quartulli <[email-masked]>
Date: Tue, 25 Dec 2012 12:26:57 +0100

On Mon, Dec 24, 2012 at 11:14:06AM +0900, Akinobu Mita wrote:
> batadv_iv_ogm_emit_send_time() attempts to calculates a random integer
> in the range of 'orig_interval +- BATADV_JITTER' by the below lines.
> 
>         msecs = atomic_read(&bat_priv->orig_interval) - BATADV_JITTER;
>         msecs += (random32() % 2 * BATADV_JITTER);
> 
> But it actually gets 'orig_interval' or 'orig_interval - BATADV_JITTER'
> because '%' and '*' have same precedence and associativity is
> left-to-right.
> 
> This adds the parentheses at the appropriate position so that it matches
> original intension.
> 
> Signed-off-by: Akinobu Mita <[email-masked]>
> Cc: Marek Lindner <[email-masked]>
> Cc: Simon Wunderlich <[email-masked]>
> Cc: Antonio Quartulli <[email-masked]>
> Cc: [email-masked]
> Cc: "David S. Miller" <davem-fT/PcQaiUtIeIZ0/[email-masked]>
> Cc: [email-masked]
> ---

Acked-by: Antonio Quartulli <[email-masked]>

But I would suggest to apply this change to net, since it is a fix.

Cheers,

-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara