Subject: Re: [PATCH net-next] team: update master carrier state

From: Flavio Leitner <[email-masked]>
Date: Sun, 30 Dec 2012 20:06:16 -0200

On Sun, Dec 30, 2012 at 10:47:23PM +0100, Jiri Pirko wrote:
> Sun, Dec 30, 2012 at 07:27:29PM CET, [email-masked] wrote:
> >Update master's carrier state when there is any
> >change with its ports.
> 
> 
> This patch looks good to me. Just one nitpick I spotted....
> 
> >+	bool team_linkup;
> >+
> >+	team_linkup = false;
> 
> 
> This can be squashed together.

Ok, but that increases the static size of the module because it
moves the variable out of bss.

I have no strong opinion on either case, so it's up to you.

Thanks,
-- 
fbl