Subject: Re: [PATCH repost] net,wireless: check against default_ethtool_ops

From: Stanislaw Gruszka <[email-masked]>
Date: Mon, 7 Jan 2013 11:44:14 +0100

On Mon, Jan 07, 2013 at 11:23:07AM +0100, Jiri Pirko wrote:
> >-static const struct ethtool_ops default_ethtool_ops;
> >+const struct ethtool_ops default_ethtool_ops;
> >+EXPORT_SYMBOL_GPL(default_ethtool_ops);
> 
> I think that default_ethtool_ops should stay static. Wouldn't it be
> nicer to introduce a helper like:
> 
> bool dev_has_default_ethtool_ops(struct net_device *dev)
> {
> 	return dev->ethtool_ops == &default_ethtool_ops;
> }

Then I still have to export this function. So with your approch, number
of exported symbols will be the same, but there will be few more lines
of code.

Stanislaw