public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Dan Carpenter <dan.carpenter@oracle•com>
To: Michael Chan <mchan@broadcom•com>
Cc: Matt Carlson <mcarlson@broadcom•com>,
	Grant Likely <grant.likely@secretlab•ca>,
	Rob Herring <rob.herring@calxeda•com>,
	netdev@vger•kernel.org, devicetree-discuss@lists•ozlabs.org,
	kernel-janitors@vger•kernel.org
Subject: [patch] tg3: missing break statement in tg3_get_5720_nvram_info()
Date: Fri, 11 Jan 2013 09:57:33 +0300	[thread overview]
Message-ID: <20130111065733.GG13207@elgon.mountain> (raw)

There is a missing break statement so FLASH_5762_EEPROM_HD gets treated
like FLASH_5762_EEPROM_LD.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle•com>
---
Only needed in linux-next.

diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index bc4d989..642764e 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -13726,8 +13726,10 @@ static void tg3_get_5720_nvram_info(struct tg3 *tp)
 		switch (nvmpinstrp) {
 		case FLASH_5762_EEPROM_HD:
 			nvmpinstrp = FLASH_5720_EEPROM_HD;
+			break;
 		case FLASH_5762_EEPROM_LD:
 			nvmpinstrp = FLASH_5720_EEPROM_LD;
+			break;
 		}
 	}
 

next             reply	other threads:[~2013-01-11  6:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-11  6:57 Dan Carpenter [this message]
2013-01-11  7:00 ` [patch] tg3: missing break statement in tg3_get_5720_nvram_info() David Miller

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:bc4d989 dfblob:642764e )
 OR (
bs:"[patch] tg3: missing break statement in tg3_get_5720_nvram_info()" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130111065733.GG13207@elgon.mountain \
    --to=dan.carpenter@oracle$(echo .)com \
    --cc=devicetree-discuss@lists$(echo .)ozlabs.org \
    --cc=grant.likely@secretlab$(echo .)ca \
    --cc=kernel-janitors@vger$(echo .)kernel.org \
    --cc=mcarlson@broadcom$(echo .)com \
    --cc=mchan@broadcom$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=rob.herring@calxeda$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox