Subject: re: ipv6: Do not depend on rt->n in rt6_probe().

From: Dan Carpenter <[email-masked]>
Date: Mon, 21 Jan 2013 21:28:58 +0300

Hello YOSHIFUJI Hideaki / 吉藤英明,

This is a semi-automatic email about new static checker warnings.

The patch 2152caea7196: "ipv6: Do not depend on rt->n in 
rt6_probe()." from Jan 17, 2013, leads to the following Smatch 
complaint:

net/ipv6/route.c:495 rt6_probe()
	 error: we previously assumed 'neigh' could be null (see line 490)

net/ipv6/route.c
   489	
   490		if (!neigh ||
                     ^^^^^
New test.

   491		    time_after(jiffies, neigh->updated + rt->rt6i_idev->cnf.rtr_probe_interval)) {
   492			struct in6_addr mcaddr;
   493			struct in6_addr *target;
   494	
   495			neigh->updated = jiffies;
                        ^^^^^^^^^^^^^^
Old dereference.

   496	
   497			if (neigh)
                            ^^^^^
Another new test.

regards,
dan carpenter