Subject: Re: [PATCH net] r8169: remove the obsolete and incorrect AMD workaround

From: Timo Teras <[email-masked]>
Date: Thu, 24 Jan 2013 08:09:11 +0200

On Wed, 23 Jan 2013 23:38:34 +0100 Francois Romieu
<[email-masked]> wrote:

> Timo Teras <[email-masked]> :
> [...]
> > Actually, this sounds wrong. Why is rtl8169_rx_vlan_tag() which is
> > fiddling opts2 invoked *after* rtl8169_mark_to_asic() ? This means
> > it can overwrite the tag info if the queue is full.
> 
> Yes. It has been there for ages.
> 
> What about something like the patch below ?

Looks good as the minimum intrusion for stable branches. Though, I'm
wondering if it'd be easy to refactor rtl_rx() so that it would
not need that many goto labels.