Subject: Re: [patch net-next v2 1/3] team: handle sending port list in the same way option list is sent

From: Pablo Neira Ayuso <[email-masked]>
Date: Fri, 1 Feb 2013 21:43:10 +0100

On Fri, Feb 01, 2013 at 08:00:26PM +0100, Jiri Pirko wrote:
> >> +send_done:
> >> +	nlh = nlmsg_put(skb, portid, seq, NLMSG_DONE, 0, flags | NLM_F_MULTI);
> >> +	if (!nlh) {
> >> +		err = __send_and_alloc_skb(&skb, team, portid, send_func);
> >> +		if (err)
> >> +			goto errout;
> >> +		goto send_done;
> >> +	}
> >
> >I'd suggest to use netlink_dump_start for this, so you don't need to
> >manually create the NLMSG_DONE message.
> 
> I believe that is not possible for genl

By looking at net/netlink/genetlink.c, you can make it by means of the
.dumpit callback in struct genl_ops. You have to pass NLM_F_DUMP from
user-space to hit that code.

BTW, perhaps it is good idea to keep the old get function that takes
no NLM_F_DUMP for a while to avoid breaking old versions of userspace
code?