Subject: Re: [patch net-next v2 1/3] team: handle sending port list in the same way option list is sent

From: Pablo Neira Ayuso <[email-masked]>
Date: Sat, 2 Feb 2013 02:29:28 +0100

On Sat, Feb 02, 2013 at 12:31:47AM +0100, Jiri Pirko wrote:
> Fri, Feb 01, 2013 at 09:43:10PM CET, [email-masked] wrote:
> >On Fri, Feb 01, 2013 at 08:00:26PM +0100, Jiri Pirko wrote:
> >> >> +send_done:
> >> >> +	nlh = nlmsg_put(skb, portid, seq, NLMSG_DONE, 0, flags | NLM_F_MULTI);
> >> >> +	if (!nlh) {
> >> >> +		err = __send_and_alloc_skb(&skb, team, portid, send_func);
> >> >> +		if (err)
> >> >> +			goto errout;
> >> >> +		goto send_done;
> >> >> +	}
> >> >
> >> >I'd suggest to use netlink_dump_start for this, so you don't need to
> >> >manually create the NLMSG_DONE message.
> >> 
> >> I believe that is not possible for genl
> >
> >By looking at net/netlink/genetlink.c, you can make it by means of the
> >.dumpit callback in struct genl_ops. You have to pass NLM_F_DUMP from
> >user-space to hit that code.
> 
> Correct. But I need to do unsolicited multicast messages as well. And
> that can't be resolved by dumpit.

Interesting. Why do you need multi-part multicast event messages?