From: Stephen Hemminger <stephen@networkplumber•org>
To: vyasevic@redhat•com
Cc: bridge@lists•linux-foundation.org, davem@davemloft•net,
netdev@vger•kernel.org
Subject: Re: [PATCH v9 net-next 00/12] Add basic VLAN support to bridges
Date: Thu, 7 Feb 2013 14:57:55 -0800 [thread overview]
Message-ID: <20130207145755.5a65062a@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <51142F20.4050008@redhat.com>
On Thu, 07 Feb 2013 17:48:00 -0500
Vlad Yasevich <vyasevic@redhat•com> wrote:
> On 02/04/2013 11:58 AM, Vlad Yasevich wrote:
> > On 02/04/2013 11:24 AM, Stephen Hemminger wrote:
> >> One thing I am not clear about is whether is supposed to be just
> >> a simple filter of VLAN traffic, or a full VLAN aware bridge.
> >
> > I started with the concept of basic VLAN filtering, but it has been
> > morphing into more of a VLAN away bridge.
> >
> >>
> >> The change to make FDB entries per-VLAN seems to be the biggest tipping
> >> point into a full VLAN bridge. I am concerned that might break existing
> >> API's and Spanning Tree (internal and external).
> >>
> >
> > I debated for a while about whether per-VLAN FDB entries were needed.
> > The typing point was that without it, you may end up with flopping FDB
> > and possible packet drops or vlan leaks, if say 2 different VMs used the
> > same MAC but different VLANs. Without it, there is an exploitable gap.
> >
> > I've also tried to separate FDB code changes as much as possible. If
> > you really thing this is a big risk and a barrier to entry, then we can
> > drop them. I am just concerned about the hole I described above, but I
> > guess it is not much different then what's there now.
> >
>
> So I played with STP for quite a bit and found the FDB changes have
> absolutely no effect on operation of STP.
> Since all the vlan filtering code is mostly in forwarding path, STP
> works just fine.
> Looking at STP code (the one in the kernel), I don't see any
> dependencies on FDB. The only userspace code I can find is from here
> git://git.kernel.org/pub/scm/linux/kernel/git/shemminger/rstp.git. That
> only seems to ask for RTM_GETLINK, and there you will not get any vlan
> information if you don't set the filter flags.
>
> So, I don't see any API impact as far as STP is concerned.
Good, does bridge command (in newer iproute2) still work?
next prev parent reply other threads:[~2013-02-07 22:58 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 20:01 [PATCH v9 net-next 00/12] Add basic VLAN support to bridges Vlad Yasevich
2013-02-01 20:01 ` [PATCH v9 net-next 01/12] bridge: Add vlan filtering infrastructure Vlad Yasevich
2013-02-02 1:04 ` Michał Mirosław
2013-02-02 2:11 ` Vlad Yasevich
2013-02-01 20:02 ` [PATCH v9 net-next 02/12] bridge: Validate that vlan is permitted on ingress Vlad Yasevich
2013-02-02 1:04 ` Michał Mirosław
2013-02-02 2:13 ` Vlad Yasevich
2013-02-01 20:02 ` [PATCH v9 net-next 03/12] bridge: Verify that a vlan is allowed to egress on give port Vlad Yasevich
2013-02-01 20:02 ` [PATCH v9 net-next 04/12] bridge: Add netlink interface to configure vlans on bridge ports Vlad Yasevich
2013-02-01 20:02 ` [PATCH v9 net-next 05/12] bridge: Add the ability to configure pvid Vlad Yasevich
2013-02-02 1:04 ` Michał Mirosław
2013-02-02 1:15 ` Michał Mirosław
2013-02-02 2:22 ` Vlad Yasevich
2013-02-03 14:49 ` Michał Mirosław
2013-02-03 15:20 ` Michał Mirosław
2013-02-04 16:59 ` Vlad Yasevich
2013-02-01 20:02 ` [PATCH v9 net-next 06/12] bridge: Implement vlan ingress/egress policy Vlad Yasevich
2013-02-01 20:02 ` [PATCH v9 net-next 07/12] bridge: Add vlan to unicast fdb entries Vlad Yasevich
2013-02-01 20:02 ` [PATCH v9 net-next 08/12] bridge: Add vlan id to multicast groups Vlad Yasevich
2013-02-01 20:02 ` [PATCH v9 net-next 09/12] bridge: Add vlan support to static neighbors Vlad Yasevich
2013-02-01 20:02 ` [PATCH v9 net-next 10/12] bridge: Add vlan support for local fdb entries Vlad Yasevich
2013-02-01 20:02 ` [PATCH v9 net-next 11/12] bridge: Dump vlan information from a bridge port Vlad Yasevich
2013-02-01 20:02 ` [PATCH v9 net-next 12/12] bridge: Separate egress policy bitmap Vlad Yasevich
2013-02-04 16:24 ` [PATCH v9 net-next 00/12] Add basic VLAN support to bridges Stephen Hemminger
2013-02-04 16:58 ` Vlad Yasevich
2013-02-07 22:48 ` Vlad Yasevich
2013-02-07 22:57 ` Stephen Hemminger [this message]
2013-02-07 23:00 ` Vlad Yasevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130207145755.5a65062a@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber$(echo .)org \
--cc=bridge@lists$(echo .)linux-foundation.org \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vyasevic@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox