From: Konrad Rzeszutek Wilk <konrad.wilk@oracle•com>
To: Wei Liu <wei.liu2@citrix•com>
Cc: xen-devel@lists•xen.org, netdev@vger•kernel.org,
ian.campbell@citrix•com, annie.li@oracle•com
Subject: Re: [PATCH 1/8] netback: don't bind kthread to cpu
Date: Mon, 4 Mar 2013 15:51:54 -0500 [thread overview]
Message-ID: <20130304205154.GB16762@phenom.dumpdata.com> (raw)
In-Reply-To: <1360944010-15336-2-git-send-email-wei.liu2@citrix.com>
On Fri, Feb 15, 2013 at 04:00:02PM +0000, Wei Liu wrote:
> The initialization process makes an assumption that the online cpus are
> numbered from 0 to xen_netbk_group_nr-1, which is not always true.
And xen_netbk_group_nr is num_online_cpus()?
So under what conditions does this change? Is this when the CPU hotplug
is involved and the CPUs go offline? In which case should there be a
CPU hotplug notifier to re-bind the workers are appropiate?
>
> As we only need a pool of worker threads, simply don't bind them to specific
> cpus.
OK. Is there another method of doing this? Are there patches to make the thread
try to be vCPU->guest affinite?
>
> Signed-off-by: Wei Liu <wei.liu2@citrix•com>
> ---
> drivers/net/xen-netback/netback.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
> index 3ae49b1..db8d45a 100644
> --- a/drivers/net/xen-netback/netback.c
> +++ b/drivers/net/xen-netback/netback.c
> @@ -1729,8 +1729,6 @@ static int __init netback_init(void)
> goto failed_init;
> }
>
> - kthread_bind(netbk->task, group);
> -
> INIT_LIST_HEAD(&netbk->net_schedule_list);
>
> spin_lock_init(&netbk->net_schedule_list_lock);
> --
> 1.7.10.4
>
next prev parent reply other threads:[~2013-03-04 20:52 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 16:00 [PATCH 0/8] Bugfix and mechanical works for Xen network driver Wei Liu
2013-02-15 16:00 ` [PATCH 1/8] netback: don't bind kthread to cpu Wei Liu
2013-03-04 20:51 ` Konrad Rzeszutek Wilk [this message]
2013-03-05 13:30 ` Wei Liu
2013-03-05 13:56 ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-03-05 14:04 ` Wei Liu
2013-03-05 14:42 ` David Vrabel
2013-03-05 15:52 ` Konrad Rzeszutek Wilk
2013-02-15 16:00 ` [PATCH 2/8] netback: add module unload function Wei Liu
2013-03-04 20:55 ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-03-04 20:58 ` Andrew Cooper
2013-03-05 13:30 ` Wei Liu
2013-03-04 21:58 ` Stephen Hemminger
2013-03-05 13:30 ` Wei Liu
2013-02-15 16:00 ` [PATCH 3/8] netback: get/put module along with vif connect/disconnect Wei Liu
2013-03-04 20:56 ` Konrad Rzeszutek Wilk
2013-03-05 10:02 ` [Xen-devel] " David Vrabel
2013-03-05 13:30 ` Wei Liu
2013-03-05 14:07 ` David Vrabel
2013-03-05 14:44 ` Wei Liu
2013-03-05 15:53 ` Konrad Rzeszutek Wilk
2013-02-15 16:00 ` [PATCH 4/8] xenbus_client: Extend interface to support multi-page ring Wei Liu
2013-02-15 16:17 ` [Xen-devel] " Jan Beulich
2013-02-15 16:33 ` Wei Liu
2013-02-15 16:59 ` Jan Beulich
2013-02-15 17:01 ` Wei Liu
2013-03-04 21:12 ` Konrad Rzeszutek Wilk
2013-03-05 10:25 ` [Xen-devel] " David Vrabel
2013-02-15 16:00 ` [PATCH 5/8] netback: multi-page ring support Wei Liu
2013-03-04 21:00 ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-03-05 10:41 ` David Vrabel
2013-02-15 16:00 ` [PATCH 6/8] netfront: " Wei Liu
2013-02-26 6:52 ` ANNIE LI
2013-02-26 12:35 ` Wei Liu
2013-02-27 7:39 ` ANNIE LI
2013-02-27 15:49 ` Wei Liu
2013-02-28 5:19 ` ANNIE LI
2013-02-28 11:02 ` Wei Liu
2013-02-28 12:55 ` annie li
2013-03-04 21:16 ` Konrad Rzeszutek Wilk
2013-02-15 16:00 ` [PATCH 7/8] netback: split event channels support Wei Liu
2013-03-04 21:22 ` Konrad Rzeszutek Wilk
2013-02-15 16:00 ` [PATCH 8/8] netfront: " Wei Liu
2013-03-04 21:24 ` Konrad Rzeszutek Wilk
2013-02-26 3:07 ` [Xen-devel] [PATCH 0/8] Bugfix and mechanical works for Xen network driver ANNIE LI
2013-02-26 11:33 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130304205154.GB16762@phenom.dumpdata.com \
--to=konrad.wilk@oracle$(echo .)com \
--cc=annie.li@oracle$(echo .)com \
--cc=ian.campbell@citrix$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=wei.liu2@citrix$(echo .)com \
--cc=xen-devel@lists$(echo .)xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox