Subject: Re: [iproute2] Fix -oneline output when alias present

From: Andreas Henriksson <[email-masked]>
Date: Wed, 13 Mar 2013 10:48:59 +0100

Hi!

Just wanted to point out some minor style issues with your patch.
See below...

On Tue, Mar 12, 2013 at 12:03:47PM -0000, [email-masked] wrote:
[...]
> -	if (do_link && tb[IFLA_IFALIAS])
> -		fprintf(fp,"\n    alias %s", 
> +	if (do_link && tb[IFLA_IFALIAS]) {
> +		fprintf(fp, "%s", _SL_);
> +		fprintf(fp,"    alias %s",

                          ^^^ missing space here.

Also, why not use a single fprintf?

Like:
                fprintf(fp, "%s    alias %s",
                        _SL_,
>  			rta_getattr_str(tb[IFLA_IFALIAS]));
> +	}

Then you wouldn't need these brackets either...

>  
>  	if (do_link && show_stats) {
>  		if (tb[IFLA_STATS64])

-- 
Andreas Henriksson