From: Stephen Hemminger <stephen@networkplumber•org>
To: Ben Greear <greearb@candelatech•com>
Cc: David Miller <davem@davemloft•net>, netdev@vger•kernel.org
Subject: Re: [PATCH] net-sysfs: make flags symmetrical
Date: Mon, 1 Apr 2013 15:04:07 -0700 [thread overview]
Message-ID: <20130401150407.0d689980@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <5159EB2B.7070504@candelatech.com>
On Mon, 01 Apr 2013 13:16:43 -0700
Ben Greear <greearb@candelatech•com> wrote:
> On 04/01/2013 11:53 AM, Stephen Hemminger wrote:
> > The flags reported by sysfs are the raw kernel flags, not the version
> > exported to user space. This leads to the unsymmetrical behaviour that
> > read != write. An example of this is when a device is part of a
> > bridge. The PROMISC flag returned from sysfs will not be the same as
> > other API's.
> >
> > The reason this patch deserves wider discussion is someone might be
> > depending on sysfs to read raw kernel flags.
>
> I am depending on this feature. There is no other way I know
> of to determine if an interface is actually currently acting
> PROMISC or not.
>
> Please don't 'fix' this.
>
> Thanks,
> Ben
>
The real problem is there isn't a netlink attribute that encodes
the real flags (there should be), and when device changes state a notification
should be sent.
next prev parent reply other threads:[~2013-04-01 22:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-01 18:53 [PATCH] net-sysfs: make flags symmetrical Stephen Hemminger
2013-04-01 20:16 ` Ben Greear
2013-04-01 21:18 ` David Miller
2013-04-01 21:32 ` Ben Greear
2013-04-01 22:04 ` Stephen Hemminger [this message]
2013-04-01 22:26 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130401150407.0d689980@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=greearb@candelatech$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox