Subject: Re: [Linux-zigbee-devel] [PATCH 2/2] at86rf230: change irq handling to prevent lockups with edge type irq

From: Werner Almesberger <[email-masked]>
Date: Fri, 5 Apr 2013 07:51:58 -0300

I wrote:
> To achieve perfection, at86rf230_probe could try all four
> possible trigger modes, pick one the platform supports, and
> set TRX_CTRL_1.IRQ_POLARITY accordingly.

Thinking of it, probing by trying request_irq has an unpleasant ring
to it. Perhaps a better way would be to leave this decision to the
platform code and do one of these:

1) pass irqflags and the polarity in the platform data, or

2) pass irqflags and extract the polarity from the irqflags, or

3) set up the trigger mode outside the driver and pass only the
   polarity,

where 1) with (irqflags & IRQF_TRIGGER_MASK) == 0 includes
case 3).

- Werner