From: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
To: linux-kernel@vger•kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
stable@vger•kernel.org, Tim Gardner <tim.gardner@canonical•com>,
Ivo van Doorn <IvDoorn@gmail•com>,
Gertjan van Wingerde <gwingerde@gmail•com>,
Helmut Schaa <helmut.schaa@googlemail•com>,
"John W. Linville" <linville@tuxdriver•com>,
linux-wireless@vger•kernel.org, users@rt2x00•serialmonkey.com,
netdev@vger•kernel.org
Subject: [ 64/64] rt2x00: rt2x00pci_regbusy_read() - only print register access failure once
Date: Wed, 10 Apr 2013 15:47:01 -0700 [thread overview]
Message-ID: <20130410224348.609013379@linuxfoundation.org> (raw)
In-Reply-To: <20130410224333.114387235@linuxfoundation.org>
3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Tim Gardner <tim.gardner@canonical•com>
commit 83589b30f1e1dc9898986293c9336b8ce1705dec upstream.
BugLink: http://bugs.launchpad.net/bugs/1128840
It appears that when this register read fails it never recovers, so
I think there is no need to repeat the same error message ad infinitum.
Signed-off-by: Tim Gardner <tim.gardner@canonical•com>
Cc: Ivo van Doorn <IvDoorn@gmail•com>
Cc: Gertjan van Wingerde <gwingerde@gmail•com>
Cc: Helmut Schaa <helmut.schaa@googlemail•com>
Cc: "John W. Linville" <linville@tuxdriver•com>
Cc: linux-wireless@vger•kernel.org
Cc: users@rt2x00•serialmonkey.com
Cc: netdev@vger•kernel.org
Cc: stable@vger•kernel.org
Signed-off-by: John W. Linville <linville@tuxdriver•com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
---
drivers/net/wireless/rt2x00/rt2x00pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/net/wireless/rt2x00/rt2x00pci.c
+++ b/drivers/net/wireless/rt2x00/rt2x00pci.c
@@ -52,8 +52,8 @@ int rt2x00pci_regbusy_read(struct rt2x00
udelay(REGISTER_BUSY_DELAY);
}
- ERROR(rt2x00dev, "Indirect register access failed: "
- "offset=0x%.08x, value=0x%.08x\n", offset, *reg);
+ printk_once(KERN_ERR "%s() Indirect register access failed: "
+ "offset=0x%.08x, value=0x%.08x\n", __func__, offset, *reg);
*reg = ~0;
return 0;
parent reply other threads:[~2013-04-10 22:47 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20130410224333.114387235@linuxfoundation.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130410224348.609013379@linuxfoundation.org \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=IvDoorn@gmail$(echo .)com \
--cc=gwingerde@gmail$(echo .)com \
--cc=helmut.schaa@googlemail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=linville@tuxdriver$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stable@vger$(echo .)kernel.org \
--cc=tim.gardner@canonical$(echo .)com \
--cc=users@rt2x00$(echo .)serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox