From: Willy Tarreau <w@1wt•eu>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail•com>
Cc: Andrew Lunn <andrew@lunn•ch>, Jason Cooper <jason@lakedaemon•net>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
linux-kernel@vger•kernel.org,
Florian Fainelli <florian@openwrt•org>,
Soeren Moch <smoch@web•de>, Paul Mackerras <paulus@samba•org>,
Lennert Buytenhek <buytenh@wantstofly•org>,
Dale Farnsworth <dale@farnsworth•org>,
netdev@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
"David S. Miller" <davem@davemloft•net>,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH] net: mv643xx_eth: Add GRO support
Date: Thu, 11 Apr 2013 15:13:33 +0200 [thread overview]
Message-ID: <20130411131333.GD1910@1wt.eu> (raw)
In-Reply-To: <1365684023-9967-1-git-send-email-sebastian.hesselbarth@gmail.com>
Hi,
On Thu, Apr 11, 2013 at 02:40:23PM +0200, Sebastian Hesselbarth wrote:
> This patch adds GRO support to mv643xx_eth by making it invoke
> napi_gro_receive instead of netif_receive_skb.
>
> Signed-off-by: Soeren Moch <smoch@web•de>
> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail•com>
> ---
> Cc: "David S. Miller" <davem@davemloft•net>
> Cc: Lennert Buytenhek <buytenh@wantstofly•org>
> Cc: Andrew Lunn <andrew@lunn•ch>
> Cc: Jason Cooper <jason@lakedaemon•net>
> Cc: Florian Fainelli <florian@openwrt•org>
> Cc: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> Cc: Paul Mackerras <paulus@samba•org>
> Cc: Dale Farnsworth <dale@farnsworth•org>
> Cc: netdev@vger•kernel.org
> Cc: linux-arm-kernel@lists•infradead.org
> Cc: linuxppc-dev@lists•ozlabs.org
> Cc: linux-kernel@vger•kernel.org
> ---
> drivers/net/ethernet/marvell/mv643xx_eth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c
> index 305038f..c850d04 100644
> --- a/drivers/net/ethernet/marvell/mv643xx_eth.c
> +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c
> @@ -604,7 +604,7 @@ static int rxq_process(struct rx_queue *rxq, int budget)
> lro_receive_skb(&rxq->lro_mgr, skb, (void *)cmd_sts);
> lro_flush_needed = 1;
> } else
> - netif_receive_skb(skb);
> + napi_gro_receive(&mp->napi, skb);
>
> continue;
I remember having experimented with this on 3.6 a few months ago with this
driver and finally switching back to something like this instead which
showed better performance on my tests :
if (skb->ip_summed == CHECKSUM_UNNECESSARY)
napi_gro_receive(napi, skb);
else
netif_receive_skb(skb);
Unfortunately I don't have more details as my commit message was rather
short due to this resulting from experimentation. Did you verify that
you did not lose any performance in various workloads ? I was playing
with bridges at this time, it's possible that I got better performance
on bridging with netif_receive_skb() than with napi_gro_receive().
Regards,
Willy
next prev parent reply other threads:[~2013-04-11 13:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 12:40 [PATCH] net: mv643xx_eth: Add GRO support Sebastian Hesselbarth
2013-04-11 13:13 ` Willy Tarreau [this message]
2013-04-11 14:47 ` Sebastian Hesselbarth
2013-04-11 15:03 ` Willy Tarreau
2013-04-11 15:27 ` Sebastian Hesselbarth
2013-04-11 15:32 ` Willy Tarreau
2013-04-11 15:54 ` Eric Dumazet
2013-04-11 16:02 ` Willy Tarreau
2013-04-11 16:10 ` Eric Dumazet
2013-04-11 16:59 ` Sebastian Hesselbarth
2013-04-11 17:13 ` Willy Tarreau
2013-04-11 17:31 ` David Miller
2013-04-11 17:35 ` Eric Dumazet
2013-04-11 17:51 ` Willy Tarreau
2013-04-11 17:59 ` Eric Dumazet
2013-04-11 18:02 ` Willy Tarreau
2013-04-11 15:54 ` Eric Dumazet
2013-04-11 17:55 ` Ben Hutchings
2013-04-11 18:07 ` Sebastian Hesselbarth
2013-04-11 20:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130411131333.GD1910@1wt.eu \
--to=w@1wt$(echo .)eu \
--cc=andrew@lunn$(echo .)ch \
--cc=benh@kernel$(echo .)crashing.org \
--cc=buytenh@wantstofly$(echo .)org \
--cc=dale@farnsworth$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=florian@openwrt$(echo .)org \
--cc=jason@lakedaemon$(echo .)net \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paulus@samba$(echo .)org \
--cc=sebastian.hesselbarth@gmail$(echo .)com \
--cc=smoch@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox