From: Arnd Bergmann <arnd@arndb•de>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org, ben@fluff•org
Subject: Re: [PATCH] net: ax88796: avoid 64 bit arithmetic
Date: Fri, 19 Apr 2013 20:46:09 +0200 [thread overview]
Message-ID: <201304192046.09566.arnd@arndb.de> (raw)
In-Reply-To: <20130419.133603.1487086024178553164.davem@davemloft.net>
On Friday 19 April 2013, David Miller wrote:
> From: Arnd Bergmann <arnd@arndb•de>
> Date: Fri, 19 Apr 2013 15:06:21 +0200
>
> > When building ax88796 on an ARM platform with 64-bit resource_size_t,
> > we currently get
> >
> > drivers/net/ethernet/8390/ax88796.c:875: undefined reference to `__aeabi_uldivmod'
> >
> > because we do a division on the length of the MMIO resource.
> > Since we know that this resource is very short, using an
> > "unsigned long" instead of "resource_size_t" is entirely
> > sufficient, and avoids this link-time error.
>
> Please provide a proper signoff with your patches, thanks.
Sorry about this, I have no idea how this slipped through. I'll
send a new version right away.
Arnd
next prev parent reply other threads:[~2013-04-19 18:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 13:06 [PATCH] net: ax88796: avoid 64 bit arithmetic Arnd Bergmann
2013-04-19 17:36 ` David Miller
2013-04-19 18:46 ` Arnd Bergmann [this message]
2013-04-19 18:47 ` [PATCH v2] " Arnd Bergmann
2013-04-19 21:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304192046.09566.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=ben@fluff$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox