From: Dan Carpenter <dan.carpenter@oracle•com>
To: Wensong Zhang <wensong@linux-vs•org>
Cc: Simon Horman <horms@verge•net.au>, Julian Anastasov <ja@ssi•bg>,
Pablo Neira Ayuso <pablo@netfilter•org>,
Patrick McHardy <kaber@trash•net>,
"David S. Miller" <davem@davemloft•net>,
netdev@vger•kernel.org, lvs-devel@vger•kernel.org,
netfilter-devel@vger•kernel.org, netfilter@vger•kernel.org,
coreteam@netfilter•org
Subject: [patch] ipvs: off by one in set_sctp_state()
Date: Sat, 20 Apr 2013 14:24:55 +0300 [thread overview]
Message-ID: <20130420112455.GA30198@elgon.mountain> (raw)
The sctp_events[] come from sch->type in set_sctp_state(). They are
between 0-255 so that means we need 256 elements in the array.
I believe that because of how the code is aligned there is normally a
hole after sctp_events[] so this patch doesn't actually change anything.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle•com>
---
This is static checker stuff. I'm not very familiar with this code.
diff --git a/net/netfilter/ipvs/ip_vs_proto_sctp.c b/net/netfilter/ipvs/ip_vs_proto_sctp.c
index 6e14a7b..8646488 100644
--- a/net/netfilter/ipvs/ip_vs_proto_sctp.c
+++ b/net/netfilter/ipvs/ip_vs_proto_sctp.c
@@ -208,7 +208,7 @@ enum ipvs_sctp_event_t {
IP_VS_SCTP_EVE_LAST
};
-static enum ipvs_sctp_event_t sctp_events[255] = {
+static enum ipvs_sctp_event_t sctp_events[256] = {
IP_VS_SCTP_EVE_DATA_CLI,
IP_VS_SCTP_EVE_INIT_CLI,
IP_VS_SCTP_EVE_INIT_ACK_CLI,
next reply other threads:[~2013-04-20 11:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-20 11:24 Dan Carpenter [this message]
2013-04-20 12:25 ` [patch] ipvs: off by one in set_sctp_state() Julian Anastasov
2013-04-22 4:11 ` Simon Horman
2013-04-22 6:03 ` Julian Anastasov
2013-04-22 9:17 ` Moahn Reddy
2013-04-22 9:30 ` Dan Carpenter
2013-04-22 9:49 ` Moahn Reddy
2013-04-23 2:22 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130420112455.GA30198@elgon.mountain \
--to=dan.carpenter@oracle$(echo .)com \
--cc=coreteam@netfilter$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=horms@verge$(echo .)net.au \
--cc=ja@ssi$(echo .)bg \
--cc=kaber@trash$(echo .)net \
--cc=lvs-devel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=netfilter@vger$(echo .)kernel.org \
--cc=pablo@netfilter$(echo .)org \
--cc=wensong@linux-vs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox