Subject: Re: [PATCH] gso: Handle Trans-Ether-Bridging protocol in skb_network_protocol()

From: Stephen Hemminger <[email-masked]>
Date: Wed, 8 May 2013 09:23:13 -0700

On Wed, 08 May 2013 00:42:49 -0700
PJ Waskiewicz <[email-masked]> wrote:

> On 5/7/2013 11:41 PM, Pravin B Shelar wrote:
> > Rather than having logic to calculate inner protocol in every
> > tunnel gso handler move it to gso code. This simplifies code.
> 
> Moving code that isn't used on a regular basis to hotpath for most 
> networking to simplify code isn't always a good thing.
> 
> Have you run tests on non-tunneled streams using GSO to make sure there 
> isn't an adverse impact to performance due to the new, untaken branch?
> 
> -PJ
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to [email-masked]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Maybe use unlikely here?
It looks like more and more of this tunnel unwrapping needs to be handled here
(vxlan? ipip?) probably want more general switch statement and per-protocol functions.