public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber•org>
To: David Miller <davem@davemloft•net>
Cc: Francois Romieu <romieu@fr•zoreil.com>, netdev@vger•kernel.org
Subject: [PATCH net 2/2]  8139cp: reset BQL when ring tx ring cleared
Date: Mon, 20 May 2013 09:54:43 -0700	[thread overview]
Message-ID: <20130520095443.2d18b2cb@nehalam.linuxnetplumber.net> (raw)

This patch cures transmit timeout's with DHCP observed
while running under KVM. When the transmit ring is cleaned out,
the Byte Queue Limit values need to be reset.

Signed-off-by: Stephen Hemminger <stephen@networkplumber•org>

--- a/drivers/net/ethernet/realtek/8139cp.c	2013-05-20 09:29:49.689900862 -0700
+++ b/drivers/net/ethernet/realtek/8139cp.c	2013-05-20 09:29:50.857880563 -0700
@@ -1141,6 +1141,7 @@ static void cp_clean_rings (struct cp_pr
 			cp->dev->stats.tx_dropped++;
 		}
 	}
+	netdev_reset_queue(cp->dev);
 
 	memset(cp->rx_ring, 0, sizeof(struct cp_desc) * CP_RX_RING_SIZE);
 	memset(cp->tx_ring, 0, sizeof(struct cp_desc) * CP_TX_RING_SIZE);

             reply	other threads:[~2013-05-20 16:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-20 16:54 Stephen Hemminger [this message]
2013-05-20 21:03 ` [PATCH net 2/2] 8139cp: reset BQL when ring tx ring cleared David Miller
2013-05-20 21:37 ` Francois Romieu
2013-05-21  0:27   ` Stephen Hemminger
2015-09-14 12:05     ` David Woodhouse
2015-09-14 21:59       ` Francois Romieu
2015-09-17 11:36         ` David Woodhouse
2015-09-17 15:06           ` David Woodhouse
2015-09-17 20:44             ` Francois Romieu
2015-09-17 22:14               ` David Woodhouse
2015-09-17 23:44                 ` Francois Romieu
2015-09-18  1:04                   ` David Woodhouse
2015-09-18  7:40                     ` David Woodhouse
2015-09-18 22:42                   ` David Woodhouse
2015-09-17 12:02         ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130520095443.2d18b2cb@nehalam.linuxnetplumber.net \
    --to=stephen@networkplumber$(echo .)org \
    --cc=davem@davemloft$(echo .)net \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=romieu@fr$(echo .)zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox