From: Timo Teras <timo.teras@iki•fi>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org, kaber@trash•net
Subject: Re: [PATCH v2 net-next] arp: flush arp cache on IFF_NOARP change
Date: Thu, 23 May 2013 10:49:44 +0300 [thread overview]
Message-ID: <20130523104944.4b7ce6c2@vostro> (raw)
In-Reply-To: <20130523.000136.1188829048647539329.davem@davemloft.net>
On Thu, 23 May 2013 00:01:36 -0700 (PDT)
David Miller <davem@davemloft•net> wrote:
> From: Timo Teräs <timo.teras@iki•fi>
> Date: Tue, 21 May 2013 13:23:44 +0300
>
> > IFF_NOARP affects what kind of neighbor entries are created
> > (nud NOARP or nud INCOMPLETE). If the flag changes, flush the arp
> > cache to refresh all entries.
> >
> > Signed-off-by: Timo Teräs <timo.teras@iki•fi>
>
> I agree with Ben that we should have a "orig_priv_flags" or
> something like that to implement this, rather than adding
> transient state flags to ->priv_flags.
Sure. I'll split this to two patches then and do this.
I would prefer "flags_changed" as then the notifiers can easily test on
the change. Usually the care only about the new state, or if it
changed. Otherwise the change calculation is needed on all notify
callbacks.
Will post this briefly, unless you feel that "orig_flags" is still
preferred.
prev parent reply other threads:[~2013-05-23 7:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 13:29 [PATCH net-next] arp: flush arp cache on IFF_NOARP change Timo Teräs
2013-05-20 20:46 ` David Miller
2013-05-21 10:23 ` [PATCH v2 " Timo Teräs
2013-05-21 16:25 ` Ben Hutchings
2013-05-21 18:29 ` Timo Teras
2013-05-21 18:54 ` Ben Hutchings
2013-05-23 7:01 ` David Miller
2013-05-23 7:49 ` Timo Teras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130523104944.4b7ce6c2@vostro \
--to=timo.teras@iki$(echo .)fi \
--cc=davem@davemloft$(echo .)net \
--cc=kaber@trash$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox