From: Stephen Hemminger <stephen@networkplumber•org>
To: Mike Rapoport <mike.rapoport@ravellosystems•com>
Cc: Cong Wang <xiyou.wangcong@gmail•com>, netdev@vger•kernel.org
Subject: Re: [PATCH iproute2] vxlan: allow specifying multiple default destinations
Date: Wed, 29 May 2013 15:56:25 -0700 [thread overview]
Message-ID: <20130529155625.2ee5f6bb@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <CAF1J0HPDAkhAybQt-tOFLLTLzaXiWy_TSbFF2FT3PMaXbnxJuw@mail.gmail.com>
On Wed, 29 May 2013 13:52:55 +0300
Mike Rapoport <mike.rapoport@ravellosystems•com> wrote:
> On Wed, May 29, 2013 at 1:13 PM, Cong Wang <xiyou.wangcong@gmail•com> wrote:
> > On Wed, 29 May 2013 at 10:00 GMT, Mike Rapoport <mike.rapoport@ravellosystems•com> wrote:
> >> Signed-off-by: Mike Rapoport <mike.rapoport@ravellosystems•com>
> >> ---
> >> ip/iplink_vxlan.c | 125 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >> 1 file changed, 125 insertions(+)
> >>
> >> diff --git a/ip/iplink_vxlan.c b/ip/iplink_vxlan.c
> >> index 1025326..be6c0ac 100644
> >> --- a/ip/iplink_vxlan.c
> >> +++ b/ip/iplink_vxlan.c
> >> @@ -28,11 +28,87 @@ static void explain(void)
> >> fprintf(stderr, " [ port MIN MAX ] [ [no]learning ]\n");
> >> fprintf(stderr, " [ [no]proxy ] [ [no]rsc ]\n");
> >> fprintf(stderr, " [ [no]l2miss ] [ [no]l3miss ]\n");
> >> + fprintf(stderr, " [ dstadd DST ]\n");
> >> + fprintf(stderr, " [ dstdel ADDR ]\n");
> >
> > Excuse me, but this looks like a design failure as you manipulate
> > remotes with `ip link` while creating vxlan devices, shouldn't this be
> > in a standard alone tool if we can't reuse any existing tool? Or am I
> > missing anything?
>
> Frankly, I had a long hesitation about the userspace implementation.
> From one side it seems very logical to use ip/iplink_vxlan for vxlan
> device manipulations. Moreover, since the remotes are used pretty much
> the same way as the group address, adding the remotes management to
> ip/iplink_vxlan makes a lot of sense. Besides, creation of stand alone
> tool for remote list manipulation in vxlan seemed to me little bit far
> fetched.
>
> On the other hand, I quite agree with you that
> ip link add vxlan0 ... dstadd 192.168.1.1
> or
> ip link set vxlan0 ... dstdel 192.168.1.1
> looks weird at least.
Don't like add/delete semantics here either.
Maybe replace or modify, or has this grown enough that having its own
command line tool "vxlan ..." makes sense?
next prev parent reply other threads:[~2013-05-29 22:56 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 10:00 [PATCH net-next v3 0/2] vxlan: allow specifying multiple default destinations Mike Rapoport
2013-05-29 10:00 ` [PATCH net-next v3 1/2] vxlan: introduce vxlan_rdst_append Mike Rapoport
2013-05-29 22:56 ` Stephen Hemminger
2013-05-30 8:42 ` Mike Rapoport
2013-05-29 10:00 ` [PATCH net-next v3 2/2] vxlan: allow specifying multiple default destinations Mike Rapoport
2013-05-30 11:09 ` Thomas Graf
2013-05-30 11:16 ` Mike Rapoport
2013-05-30 11:37 ` Thomas Graf
2013-05-31 16:17 ` Stephen Hemminger
2013-06-02 10:29 ` Mike Rapoport
2013-06-03 15:57 ` Stephen Hemminger
2013-06-03 19:47 ` Mike Rapoport
2013-06-03 18:26 ` [RFC] vxlan: convert remote list to list_rcu Stephen Hemminger
2013-06-03 20:18 ` David Stevens
2013-06-03 20:45 ` Stephen Hemminger
2013-06-03 21:46 ` David Stevens
2013-06-04 9:18 ` Mike Rapoport
2013-06-04 12:48 ` David Stevens
2013-06-04 17:20 ` Mike Rapoport
2013-06-04 19:02 ` David Stevens
2013-06-05 12:53 ` Mike Rapoport
2013-06-04 9:10 ` Mike Rapoport
2013-06-04 16:00 ` Stephen Hemminger
2013-06-04 16:29 ` David Stevens
2013-06-04 17:22 ` Mike Rapoport
2013-05-29 10:00 ` [PATCH iproute2] vxlan: allow specifying multiple default destinations Mike Rapoport
2013-05-29 10:13 ` Cong Wang
2013-05-29 10:52 ` Mike Rapoport
2013-05-29 22:56 ` Stephen Hemminger [this message]
2013-05-30 8:42 ` Mike Rapoport
2013-05-30 11:44 ` Thomas Graf
2013-05-30 12:46 ` Mike Rapoport
2013-05-30 15:57 ` Thomas Graf
2013-06-02 7:09 ` Mike Rapoport
2013-06-05 4:30 ` Stephen Hemminger
2013-06-05 12:58 ` Mike Rapoport
2013-05-30 17:07 ` Stephen Hemminger
-- strict thread matches above, loose matches on Subject: below --
2016-09-18 17:41 Tomasz Chmielewski
2013-05-28 8:31 [PATCH net-next v2 0/2] " Mike Rapoport
2013-05-28 8:33 ` [PATCH iproute2] " Mike Rapoport
2013-04-25 11:03 [PATCH net-next 0/2] " Mike Rapoport
2013-04-25 11:04 ` [PATCH iproute2] " Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130529155625.2ee5f6bb@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber$(echo .)org \
--cc=mike.rapoport@ravellosystems$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox