Subject: Re: [PATCH net-next v3 1/2] vxlan: introduce vxlan_rdst_append

From: Stephen Hemminger <[email-masked]>
Date: Wed, 29 May 2013 15:56:42 -0700

On Wed, 29 May 2013 13:00:15 +0300
Mike Rapoport <[email-masked]> wrote:

> -/* Add/update destinations for multicast */
> -static int vxlan_fdb_append(struct vxlan_fdb *f,
> -			    __be32 ip, __be16 port, __u32 vni, __u32 ifindex)
> +static int vxlan_rdst_append(struct vxlan_rdst *rdst, __be32 ip, __be16 port,
> +			     __u32 vni, __u32 ifindex)
>  {
>  	struct vxlan_rdst *rd_prev, *rd;
>  
>  	rd_prev = NULL;
> -	for (rd = &f->remote; rd; rd = rd->remote_next) {
> +	for (rd = rdst; rd; rd = rd->remote_next) {

The remote destinations should be using one of our nice list macros.
And what about locking? or RCU?