Subject: Re: [PATCH] net: ipv6: Fix incompatible pointer type warning

From: Emil Goode <[email-masked]>
Date: Wed, 5 Jun 2013 12:23:54 +0200

Hello David,

I'm sorry, the patch applies to the linux-next tree.
In the future I will be very careful about sending patches that fix
problems related to the merging of different trees.

Best regards,

Emil Goode

On Tue, Jun 04, 2013 at 05:14:56PM -0700, David Miller wrote:
> From: Emil Goode <[email-masked]>
> Date: Mon,  3 Jun 2013 14:21:08 +0200
> 
> > This fixes the sparse warning below about assignment from
> > incompatible pointer type.
> > 
> > In the following commit the third argument in function ipv6_chk_addr
> > was changed to const and struct nf_ipv6_ops was introduced with
> > the third argument of .chk_addr beeing const.
> > 
> > 2a7851bffb008ff4882eee673da74718997b4265
> > ("netfilter: add nf_ipv6_ops hook to fix xt_addrtype with IPv6")
> > 
> > The below commit introduced the warning as the third argument of
> > dummy_ipv6_chk_addr and .ipv6_chk_addr in struct pingv6_ops is
> > missing a const.
> > 
> > 6d0bfe22611602f36617bc7aa2ffa1bbb2f54c67
> > ("net: ipv6: Add IPv6 support to the ping socket.")
> > 
> > Sparse output:
> > 
> > net/ipv6/ping.c: In function ‘pingv6_init’:
> > net/ipv6/ping.c:87:27: warning:
> > 	assignment from incompatible pointer type [enabled by default]
> > 
> > Signed-off-by: Emil Goode <[email-masked]>
> 
> This only happens when you combine net with net-next, therefore your
> patch isn't actually relevent to any real GIT tree.
> 
> Please make this very clear in the future.