From: Greg KH <greg@kroah•com>
To: Ian Campbell <ian.campbell@citrix•com>
Cc: stable@vger•kernel.org, "David S. Miller" <davem@davemloft•net>,
xen-devel <xen-devel@lists•xen.org>,
netdev@vger•kernel.org, Wei Liu <wei.liu2@citrix•com>
Subject: Re: xen-netback stable backports request (regression fixes)
Date: Wed, 5 Jun 2013 14:08:07 -0700 [thread overview]
Message-ID: <20130605210807.GA15455@kroah.com> (raw)
In-Reply-To: <1370465579.6652.14.camel@hastur.hellion.org.uk>
On Wed, Jun 05, 2013 at 09:52:59PM +0100, Ian Campbell wrote:
> On Wed, 2013-06-05 at 13:25 -0700, Greg KH wrote:
> > > For the first we thought that allocating a variable size array on the
> > > stack was bad practice which could lead to a stack overflow. The default
> > > is safe but can be overridden by a module parameter.
> > >
> > > The other renames the module parameter which we thought was useful for
> > > consistency between newer kernels and the stable branches.
> >
> > So you are doing a user/kernel api change in a stable branch? Heck, you
> > did it in 3.10? Why? What did you just break by doing that? I can't
> > do that to users of the stable kernels, sorry, and you shouldn't be
> > doing that to users of the 3.10 kernel either. You should rename this
> > back so people's working systems don't break when they upgrade their
> > kernel.
>
> The module parameter was introduce after 3.9 and then renamed before
> v3.10-rc1 happened, the original name was never part of an -rc let alone
> an actual release.
Ah, ok, my mistake then, I'll go apply this to keep things synced up.
sorry for the confusion, too many patches at once to handle in the
short-term memory...
greg k-h
next prev parent reply other threads:[~2013-06-05 21:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 9:47 xen-netback stable backports request (regression fixes) Ian Campbell
2013-05-28 11:27 ` Luis Henriques
2013-05-31 13:20 ` [Xen-devel] " William Dauchy
2013-05-31 13:45 ` William Dauchy
2013-06-03 13:50 ` Ian Campbell
2013-06-05 4:55 ` Greg KH
2013-06-05 8:56 ` Ian Campbell
2013-06-05 20:25 ` Greg KH
2013-06-05 20:52 ` Ian Campbell
2013-06-05 21:08 ` Greg KH [this message]
2013-06-05 21:10 ` [Xen-devel] " Ian Campbell
2013-06-05 13:19 ` Wei Liu
2013-06-13 2:38 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130605210807.GA15455@kroah.com \
--to=greg@kroah$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ian.campbell@citrix$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stable@vger$(echo .)kernel.org \
--cc=wei.liu2@citrix$(echo .)com \
--cc=xen-devel@lists$(echo .)xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox