From: "Michael S. Tsirkin" <mst@redhat•com>
To: Qin Chuanyu <qinchuanyu@huawei•com>
Cc: jasowang@redhat•com, kvm@vger•kernel.org, netdev@vger•kernel.org
Subject: Re: [PATCH] vhost: wake up worker outside spin_lock
Date: Sun, 9 Jun 2013 12:47:01 +0300 [thread overview]
Message-ID: <20130609094701.GA14832@redhat.com> (raw)
In-Reply-To: <51B1E518.1070003@huawei.com>
On Fri, Jun 07, 2013 at 09:50:16PM +0800, Qin Chuanyu wrote:
> the wake_up_process func is included by spin_lock/unlock in
> vhost_work_queue,
> but it could be done outside the spin_lock.
> I have test it with kernel 3.0.27 and guest suse11-sp2 using iperf,
> the num as below.
> original modified
> thread_num tp(Gbps) vhost(%) | tp(Gbps) vhost(%)
> 1 9.59 28.82 | 9.59 27.49
> 8 9.61 32.92 | 9.62 26.77
> 64 9.58 46.48 | 9.55 38.99
> 256 9.6 63.7 | 9.6 52.59
>
> Signed-off-by: Chuanyu Qin <qinchuanyu@huawei•com>
> ---
> drivers/vhost/vhost.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
> index 94dbd25..dcc7a17 100644
> --- a/drivers/vhost/vhost.c
> +++ b/drivers/vhost/vhost.c
> @@ -146,9 +146,11 @@ static inline void vhost_work_queue(struct
> vhost_dev *dev,
Applied and queued for 3.11, thanks.
This patch is malformed because of the wrapped line above.
I've applied this by hand, so just FYI, please see
Documentation/email-clients.txt
for some hints on configuring mail properly.
> if (list_empty(&work->node)) {
> list_add_tail(&work->node, &dev->work_list);
> work->queue_seq++;
> + spin_unlock_irqrestore(&dev->work_lock, flags);
> wake_up_process(dev->worker);
> + } else {
> + spin_unlock_irqrestore(&dev->work_lock, flags);
> }
> - spin_unlock_irqrestore(&dev->work_lock, flags);
> }
>
> void vhost_poll_queue(struct vhost_poll *poll)
> --
> 1.7.3.1.msysgit.0
>
next prev parent reply other threads:[~2013-06-09 9:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 13:50 [PATCH] vhost: wake up worker outside spin_lock Qin Chuanyu
2013-06-07 14:05 ` Asias He
2013-06-09 9:47 ` Michael S. Tsirkin [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-06-07 10:59 Qinchuanyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130609094701.GA14832@redhat.com \
--to=mst@redhat$(echo .)com \
--cc=jasowang@redhat$(echo .)com \
--cc=kvm@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=qinchuanyu@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox