From: Simon Horman <horms@verge•net.au>
To: Dan Carpenter <dan.carpenter@oracle•com>,
Pablo Neira Ayuso <pablo@netfilter•org>
Cc: Wensong Zhang <wensong@linux-vs•org>,
Julian Anastasov <ja@ssi•bg>, Patrick McHardy <kaber@trash•net>,
Jozsef Kadlecsik <kadlec@blackhole•kfki.hu>,
"David S. Miller" <davem@davemloft•net>,
netdev@vger•kernel.org, lvs-devel@vger•kernel.org,
netfilter-devel@vger•kernel.org, netfilter@vger•kernel.org,
coreteam@netfilter•org, kernel-janitors@vger•kernel.org
Subject: Re: [patch] ipvs: info leak in __ip_vs_get_dest_entries()
Date: Mon, 10 Jun 2013 17:38:50 +0900 [thread overview]
Message-ID: <20130610083849.GD1563@verge.net.au> (raw)
In-Reply-To: <20130603090049.GA16171@debian>
On Mon, Jun 03, 2013 at 12:00:49PM +0300, Dan Carpenter wrote:
> The entry struct has a 2 byte hole after ->port and another 4 byte
> hole after ->stats.outpkts. You must have CAP_NET_ADMIN in your
> namespace to hit this information leak.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle•com>
Signed-off-by: Simon Horman <horms@verge•net.au>
Pablo, could you take this directly into your tree.
If possible for v3.10. It also appears to be relevant for stable.
>
> diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
> index df05c1c..e336535 100644
> --- a/net/netfilter/ipvs/ip_vs_ctl.c
> +++ b/net/netfilter/ipvs/ip_vs_ctl.c
> @@ -2542,6 +2542,7 @@ __ip_vs_get_dest_entries(struct net *net, const struct ip_vs_get_dests *get,
> struct ip_vs_dest *dest;
> struct ip_vs_dest_entry entry;
>
> + memset(&entry, 0, sizeof(entry));
> list_for_each_entry(dest, &svc->destinations, n_list) {
> if (count >= get->num_dests)
> break;
> --
> To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-06-10 8:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 9:00 [patch] ipvs: info leak in __ip_vs_get_dest_entries() Dan Carpenter
2013-06-03 20:00 ` Julian Anastasov
2013-06-04 1:03 ` Simon Horman
2013-06-07 8:33 ` Dan Carpenter
2013-06-10 8:38 ` Simon Horman [this message]
2013-06-10 12:58 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130610083849.GD1563@verge.net.au \
--to=horms@verge$(echo .)net.au \
--cc=coreteam@netfilter$(echo .)org \
--cc=dan.carpenter@oracle$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ja@ssi$(echo .)bg \
--cc=kaber@trash$(echo .)net \
--cc=kadlec@blackhole$(echo .)kfki.hu \
--cc=kernel-janitors@vger$(echo .)kernel.org \
--cc=lvs-devel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=netfilter@vger$(echo .)kernel.org \
--cc=pablo@netfilter$(echo .)org \
--cc=wensong@linux-vs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox