From: Stephen Hemminger <stephen@networkplumber•org>
To: David Miller <davem@davemloft•net>
Cc: eliezer.tamir@linux•intel.com, linux-kernel@vger•kernel.org,
netdev@vger•kernel.org, jesse.brandeburg@intel•com,
donald.c.skidmore@intel•com, e1000-devel@lists•sourceforge.net,
willemb@google•com, erdnetdev@gmail•com,
bhutchings@solarflare•com, andi@firstfloor•org, hpa@zytor•com,
eilong@broadcom•com, or.gerlitz@gmail•com, amirv@mellanox•com,
eliezer@tamir•org.il
Subject: Re: [PATCH net-next 1/2] net: remove NET_LL_RX_POLL config menue
Date: Wed, 12 Jun 2013 19:01:03 -0700 [thread overview]
Message-ID: <20130612190103.1545e310@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <20130612.151205.1822920389019274346.davem@davemloft.net>
On Wed, 12 Jun 2013 15:12:05 -0700 (PDT)
David Miller <davem@davemloft•net> wrote:
> From: Eliezer Tamir <eliezer.tamir@linux•intel.com>
> Date: Tue, 11 Jun 2013 17:24:28 +0300
>
> > depends on X86_TSC
>
> Wait a second, I didn't notice this before. There needs to be a better
> way to test for the accuracy you need, or if the issue is lack of a proper
> API for cycle counter reading, fix that rather than add ugly arch
> specific dependencies to generic networking code.
This should be sched_clock(), rather than direct TSC access.
Also any code using TSC or sched_clock has to be carefully audited to deal with
clocks running at different rates on different CPU's. Basically value is only
meaning full on same CPU.
next prev parent reply other threads:[~2013-06-13 2:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 14:24 [PATCH net-next 0/2] net: low latency sockets follow ups Eliezer Tamir
2013-06-11 14:24 ` [PATCH net-next 1/2] net: remove NET_LL_RX_POLL config menue Eliezer Tamir
2013-06-12 22:12 ` David Miller
2013-06-13 2:01 ` Stephen Hemminger [this message]
2013-06-13 2:13 ` Eliezer Tamir
2013-06-13 8:00 ` Daniel Borkmann
2013-06-13 10:09 ` Eliezer Tamir
2013-06-11 14:24 ` [PATCH net-next 2/2] net:add socket option for low latency polling Eliezer Tamir
2013-06-11 14:45 ` Eric Dumazet
2013-06-11 15:37 ` Eliezer Tamir
2013-06-11 15:58 ` Eric Dumazet
2013-06-11 20:24 ` Ben Hutchings
2013-06-12 6:39 ` Eliezer Tamir
2013-06-11 14:26 ` [PATCH] sockperf: add SO_LL socketop support Eliezer Tamir
2013-06-12 8:36 ` Amir Vadai
2013-06-12 8:45 ` Eliezer Tamir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130612190103.1545e310@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber$(echo .)org \
--cc=amirv@mellanox$(echo .)com \
--cc=andi@firstfloor$(echo .)org \
--cc=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=donald.c.skidmore@intel$(echo .)com \
--cc=e1000-devel@lists$(echo .)sourceforge.net \
--cc=eilong@broadcom$(echo .)com \
--cc=eliezer.tamir@linux$(echo .)intel.com \
--cc=eliezer@tamir$(echo .)org.il \
--cc=erdnetdev@gmail$(echo .)com \
--cc=hpa@zytor$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=or.gerlitz@gmail$(echo .)com \
--cc=willemb@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox