Subject: Re: [net-next 3/8] i40e: driver ethtool core

From: Stephen Hemminger <[email-masked]>
Date: Wed, 19 Jun 2013 11:40:09 -0700

On Thu, 13 Jun 2013 20:55:17 -0700
Jeff Kirsher <[email-masked]> wrote:

> +
> +/**
> + * i40e_set_settings - Set Speed and Duplex
> + * @netdev: network interface device structure
> + * @ecmd: ethtool command
> + *
> + * Set speed/duplex per media_types advertised/forced
> + **/
> +static int i40e_set_settings(struct net_device *netdev,
> +			     struct ethtool_cmd *ecmd)
> +{
> +	return -EOPNOTSUPP;
> +}
> +

Stub not needed, if ethtool_ops.set_settings is NULL, then ethtool_set_settings
will do this for you.

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
E1000-devel mailing list
[email-masked]
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit http://communities.intel.com/community/wired