public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Andi Kleen <andi@firstfloor•org>
To: Eliezer Tamir <eliezer.tamir@linux•intel.com>
Cc: Willem de Bruijn <willemb@google•com>,
	Or Gerlitz <or.gerlitz@gmail•com>,
	e1000-devel@lists•sourceforge.net, netdev@vger•kernel.org,
	HPA <hpa@zytor•com>, Amir Vadai <amirv@mellanox•com>,
	Jesse Brandeburg <jesse.brandeburg@intel•com>,
	Alex Rosenbaum <alexr@mellanox•com>,
	linux-kernel@vger•kernel.org,
	Eliezer Tamir <eliezer@tamir•org.il>,
	Andi Kleen <andi@firstfloor•org>,
	Ben Hutchings <bhutchings@solarflare•com>,
	Eric Dumazet <erdnetdev@gmail•com>,
	Eilon Greenstien <eilong@broadcom•com>,
	David Miller <davem@davemloft•net>
Subject: Re: [PATCH v4 net-next] net: poll/select low latency socket support
Date: Fri, 28 Jun 2013 06:43:05 +0200	[thread overview]
Message-ID: <20130628044305.GQ6123@two.firstfloor.org> (raw)
In-Reply-To: <20130624072803.26134.41593.stgit@ladj378.jer.intel.com>

> @@ -400,6 +402,8 @@ int do_select(int n, fd_set_bits *fds, struct timespec *end_time)
>  	poll_table *wait;
>  	int retval, i, timed_out = 0;
>  	unsigned long slack = 0;
> +	unsigned int ll_flag = POLL_LL;
> +	u64 ll_time = ll_end_time();

So you're adding a sched_clock to every select call, even if it has
nothing to do with ll? 

That seems rather drastic. select can be performance critical.

-andi

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
E1000-devel mailing list
E1000-devel@lists•sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit http://communities.intel.com/community/wired

next prev parent reply	other threads:[~2013-06-28  4:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-24  7:27 [PATCH v4 net-next 0/1] net: lls select poll support Eliezer Tamir
2013-06-24  7:28 ` [PATCH v4 net-next] net: poll/select low latency socket support Eliezer Tamir
2013-06-25 23:36   ` David Miller
2013-06-28  0:25   ` Cody P Schafer
2013-06-28  0:29     ` Cody P Schafer
2013-06-28  6:00       ` Eliezer Tamir
2013-06-28  4:43   ` Andi Kleen [this message]
2013-06-28  5:32     ` Eliezer Tamir

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130628044305.GQ6123@two.firstfloor.org \
    --to=andi@firstfloor$(echo .)org \
    --cc=alexr@mellanox$(echo .)com \
    --cc=amirv@mellanox$(echo .)com \
    --cc=bhutchings@solarflare$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=e1000-devel@lists$(echo .)sourceforge.net \
    --cc=eilong@broadcom$(echo .)com \
    --cc=eliezer.tamir@linux$(echo .)intel.com \
    --cc=eliezer@tamir$(echo .)org.il \
    --cc=erdnetdev@gmail$(echo .)com \
    --cc=hpa@zytor$(echo .)com \
    --cc=jesse.brandeburg@intel$(echo .)com \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=or.gerlitz@gmail$(echo .)com \
    --cc=willemb@google$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox