Subject: Re: [PATCH v3] iwl3945: better skb management in rx path

From: Stanislaw Gruszka <[email-masked]>
Date: Mon, 1 Jul 2013 14:15:53 +0200

On Fri, Jun 28, 2013 at 08:05:06AM -0700, Eric Dumazet wrote:
> From: Eric Dumazet <[email-masked]>
> 
> Steinar reported reallocations of skb->head with IPv6, leading to
> a warning in skb_try_coalesce()
> 
> It turns out iwl3945 has several problems :
> 
> 1) skb->truesize is underestimated. 
>    We really consume PAGE_SIZE bytes for a fragment,
>    not the frame length.
> 2) 128 bytes of initial headroom is a bit low and forces reallocations.
> 3) We can avoid consuming a full page for small enough frames.
> 
> Reported-by: Steinar H. Gunderson <[email-masked]>
> Signed-off-by: Eric Dumazet <[email-masked]>
> Cc: Paul Stewart <[email-masked]>

Acked-by: Stanislaw Gruszka <[email-masked]>

FYI, I'll post 4965 version soon.