Subject: Re: [PATCH v2] tile: support PTP using the tilegx mPIPE (IEEE 1588)

From: Richard Cochran <[email-masked]>
Date: Thu, 25 Jul 2013 19:55:42 +0200

On Thu, Jul 25, 2013 at 11:19:38AM -0400, Chris Metcalf wrote:
> Signed-off-by: Chris Metcalf <[email-masked]>
> ---
> v2:
>  - Moved Kconfig stanza to drivers/ethernet/tile/Kconfig
>  - Clarify minimum and maximum frequency adjustments

So if the requested frequency adjustment lies within the +/-30 ppm
interval, then you return EINVAL? Maybe ERANGE would be better.
Perhaps the driver should just round to the closest value it can
support? Unfortunately, we don't have a way to communicate this kind
of limitation to user space.

>  - Merge PTP support into tilegx.c driver source code directly
>  - Support SIOCSHWTSTAMP ioctl appopriately
>  - Rebased to be the last patch in the series to simplify development

Anyhow, this looks much better to me now.

Acked-by: Richard Cochran <[email-masked]>