Subject: Re: [PATCH 5/5] netfilter: add IPv6 SYNPROXY target

From: Patrick McHardy <[email-masked]>
Date: Wed, 7 Aug 2013 22:57:18 +0200

On Wed, Aug 07, 2013 at 10:34:40PM +0200, Jesper Dangaard Brouer wrote:
> 
> On Wed,  7 Aug 2013 19:42:51 +0200 Patrick McHardy <[email-masked]> wrote:
> 
> > Add an IPv6 version of the SYNPROXY target. The main differences to
> > the IPv4 version is routing and IP header construction.
> > 
> > Signed-off-by: Patrick McHardy <[email-masked]>
> 
> > +static int synproxy_tg6_check(const struct xt_tgchk_param *par)
> > +{
> > +	/// XXX PROTO match TCP
> 
> Ups, this looks like an comment to your self ;-)
> 
> > +	return nf_ct_l3proto_try_module_get(par->family);
> > +}

Oops right, I intended to add a check for proto TCP match in the rule
to make sure thoff is initialized by ip6tables.

I'll wait for more comments before sending an updated series.