From: Steffen Klassert <steffen.klassert@secunet•com>
To: Eric Dumazet <eric.dumazet@gmail•com>,
netdev@vger•kernel.org, vi0oss@gmail•com
Subject: Re: [PATCH RFC] xfrm{4,6}: only report errors back to local sockets if we don't cross address family
Date: Mon, 12 Aug 2013 07:54:14 +0200 [thread overview]
Message-ID: <20130812055414.GK25511@secunet.com> (raw)
In-Reply-To: <20130810161629.GR14001@order.stressinduktion.org>
On Sat, Aug 10, 2013 at 06:16:29PM +0200, Hannes Frederic Sowa wrote:
>
> Seems skb->encapsulated helps, but I still have to wire it up for the ipv6
> tunnels.
>
> I just prototyped this patch, but I fear I now introduced a dependency
> from core xfrm to ipv6, which I would like to have prevented (this would
> even happen if I put xfrm_local_error in a header file). Is this actually
> a problem? I fear so. The other way would be to put the local_error
> handler as function pointers somewhere reachable from struct sock.
>
Maybe we should put a local_error() function pointer to struct
xfrm_state_afinfo and call it via inner_mode->afinfo->local_error().
This should always call the right local_error function and we
would not need to touch generic networking code to fix it.
next prev parent reply other threads:[~2013-08-12 5:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 14:50 [PATCH RFC] xfrm{4,6}: only report errors back to local sockets if we don't cross address family Hannes Frederic Sowa
2013-07-30 8:21 ` Steffen Klassert
2013-07-30 8:30 ` Hannes Frederic Sowa
2013-07-30 10:26 ` Steffen Klassert
2013-07-30 10:40 ` Hannes Frederic Sowa
2013-07-31 0:01 ` David Miller
2013-08-01 8:11 ` Hannes Frederic Sowa
2013-08-01 10:05 ` Steffen Klassert
2013-08-08 22:44 ` Hannes Frederic Sowa
2013-08-08 22:57 ` Eric Dumazet
2013-08-08 23:06 ` Hannes Frederic Sowa
2013-08-10 16:16 ` Hannes Frederic Sowa
2013-08-12 5:54 ` Steffen Klassert [this message]
2013-08-13 0:48 ` [PATCH net-next] xfrm: make local error reporting more robust Hannes Frederic Sowa
2013-08-13 1:56 ` [PATCH net-next v2] " Hannes Frederic Sowa
2013-08-13 23:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130812055414.GK25511@secunet.com \
--to=steffen.klassert@secunet$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vi0oss@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox