From: Dan Carpenter <dan.carpenter@oracle•com>
To: "David S. Miller" <davem@davemloft•net>
Cc: John Fastabend <john.r.fastabend@intel•com>,
Jiri Pirko <jiri@resnulli•us>,
Vlad Yasevich <vyasevic@redhat•com>,
"Eric W. Biederman" <ebiederm@xmission•com>,
netdev@vger•kernel.org, kernel-janitors@vger•kernel.org
Subject: [patch] rtnetlink: remove an unneeded test
Date: Wed, 14 Aug 2013 12:35:42 +0300 [thread overview]
Message-ID: <20130814093542.GC521@elgon.mountain> (raw)
We know that "dev" is a valid pointer at this point, so we can remove
the test and clean up a little.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle•com>
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 618dbe4..e7e058e 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -1867,10 +1867,10 @@ replay:
else
err = register_netdevice(dev);
- if (err < 0 && !IS_ERR(dev))
+ if (err < 0) {
free_netdev(dev);
- if (err < 0)
goto out;
+ }
err = rtnl_configure_link(dev, ifm);
if (err < 0)
next reply other threads:[~2013-08-14 9:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 9:35 Dan Carpenter [this message]
2013-08-14 19:35 ` [patch] rtnetlink: remove an unneeded test Eric W. Biederman
2013-08-15 8:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130814093542.GC521@elgon.mountain \
--to=dan.carpenter@oracle$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ebiederm@xmission$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=john.r.fastabend@intel$(echo .)com \
--cc=kernel-janitors@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vyasevic@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox