From: Stephen Hemminger <stephen@networkplumber•org>
To: David Miller <davem@davemloft•net>
Cc: dborkman@redhat•com, netdev@vger•kernel.org, dborkmann@redhat•com
Subject: Re: [PATCH net] net: netlink: filter particular protocols from analyzers
Date: Thu, 5 Sep 2013 11:57:55 -0700 [thread overview]
Message-ID: <20130905115755.7aec533c@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <20130905.144442.2085221662776542385.davem@davemloft.net>
On Thu, 05 Sep 2013 14:44:42 -0400 (EDT)
David Miller <davem@davemloft•net> wrote:
> From: Daniel Borkmann <dborkman@redhat•com>
> Date: Thu, 5 Sep 2013 17:48:47 +0200
>
> > From: Daniel Borkmann <dborkmann@redhat•com>
> >
> > Fix finer-grained control and let only a whitelist of allowed netlink
> > protocols pass, in our case related to networking. If later on, other
> > subsystems decide they want to add their protocol as well to the list
> > of allowed protocols they shall simply add it. While at it, we also
> > need to tell what protocol is in use otherwise BPF_S_ANC_PROTOCOL can
> > not pick it up (as it's not filled out).
> >
> > Signed-off-by: Daniel Borkmann <dborkman@redhat•com>
>
> This takes away functionality that I'd be more interesting in using,
> namely being able to listen to all netlink protocols using one tap.
>
> Seriously, when I first saw this feature, that was the first way I'd
> imagine myself using it, as a tcpdump for netlink traffic, all of
> it.
>
> If I just want to hear all netlink traffic, don't make me be forced to
> know every single NETLINK_* protocol value and have to open that many
> sockets just to do so.
>
> It also makes it so that I can't listen to userlevel custom netlink
> protocols, another minus of filtering.
>
> At the very least, allow an sk_protocol of zero or similar to have this
> meaning of "everything".
>
> I'm not applying this patch, sorry.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
If you want filtering, why not add BPF (sk_filter) support to this?
next prev parent reply other threads:[~2013-09-05 18:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 15:48 [PATCH net] net: netlink: filter particular protocols from analyzers Daniel Borkmann
2013-09-05 18:44 ` David Miller
2013-09-05 18:57 ` Stephen Hemminger [this message]
2013-09-05 19:03 ` David Miller
2013-09-05 19:44 ` Stephen Hemminger
2013-09-05 19:50 ` David Miller
2013-09-05 19:48 ` Daniel Borkmann
2013-09-05 19:54 ` David Miller
2013-09-05 19:59 ` Daniel Borkmann
2013-09-05 20:07 ` David Miller
2013-09-06 18:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130905115755.7aec533c@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dborkman@redhat$(echo .)com \
--cc=dborkmann@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox