From: Stephen Hemminger <stephen@networkplumber•org>
To: "Williams, Mitch A" <mitch.a.williams@intel•com>
Cc: Joe Perches <joe@perches•com>,
"Brandeburg, Jesse" <jesse.brandeburg@intel•com>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel•com>,
"davem@davemloft•net" <davem@davemloft•net>,
"e1000-devel@lists•sourceforge.net"
<e1000-devel@lists•sourceforge.net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"gospo@redhat•com" <gospo@redhat•com>,
"sassmann@redhat•com" <sassmann@redhat•com>
Subject: Re: [E1000-devel] [net-next v5 8/8] i40e: include i40e in kernel proper
Date: Fri, 6 Sep 2013 10:39:05 -0700 [thread overview]
Message-ID: <20130906103905.125c2fa8@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <AAEA33E297BCAC4B9BB20A7C2DF0AB8D5C3B0A3D@FMSMSX113.amr.corp.intel.com>
On Fri, 6 Sep 2013 17:28:09 +0000
"Williams, Mitch A" <mitch.a.williams@intel•com> wrote:
> > -----Original Message-----
> > From: netdev-owner@vger•kernel.org [mailto:netdev-owner@vger•kernel.org] On
> > Behalf Of Joe Perches
> > Sent: Thursday, September 05, 2013 11:47 PM
> > To: Brandeburg, Jesse
> > Cc: Stephen Hemminger; Kirsher, Jeffrey T; davem@davemloft•net; e1000-
> > devel@lists•sourceforge.net; netdev@vger•kernel.org; gospo@redhat•com;
> > sassmann@redhat•com
> > Subject: Re: [E1000-devel] [net-next v5 8/8] i40e: include i40e in kernel
> > proper
> >
> > On Fri, 2013-09-06 at 06:28 +0000, Brandeburg, Jesse wrote:
> > > On Sep 5, 2013, at 11:15 PM, "Stephen Hemminger"
> > <stephen@networkplumber.org<mailto:stephen@networkplumber•org>> wrote:
> > >
> > > Dumb question why is this named Kbuild instead of Makefile like almost
> > > every other network driver?
> > >
> > > All the new kids are doing it, we'll at least that is what I thought when
> > I made it.
> > >
> > > Re-reading https://www.kernel.org/doc/Documentation/kbuild/makefiles.txt
> > >
> > > I see that Makefile is preferred but Kbuild overrides Makefile.
> > >
> > > Either way works, but I would prefer not to rename it at this point but
> > would gladly do so in a follow up patch
> >
> > Please do.
> >
> > I suppose it makes _some_ sense to use Kbuild in the
> > include paths but I think Makefile in places where
> > compilations are done is better.
> >
>
> That was me. I did it to make things less confusing for our customers and for us as engineers.
>
> My goal was to make our out-of-tree driver as close as possible - including the makefiles - to the upstream driver. Doing this makes it simpler for us to backport and forward-port patches. It makes it less confusing for us when we're moving from one environment to the other.
>
> The Kbuild file submitted here is exactly the same file that will be included in our out-of-tree tarball. To avoid confusion, I named it Kbuild, so nobody would just run make in the source directory. The toplevel makefile in our tarball is named Makefile, and I wanted that to be the only Makefile around so nobody would be confused (including me).
>
> The kernel documentation specifically states that this is acceptable (Documentation/kbuild/modules.txt). Furthermore, Documentation/kbuild/makefiles.txt states that using Kbuild as a filename is acceptable.
>
> Personally, I'd prefer to keep these named Kbuild. Doing so makes it simpler to keep our in-tree and out-of-tree drivers in sync. But if you're really passionate about having them named Makefile, we can deal with it. It's just one more detail for us to keep track of (and potentially screw up).
>
> If there is a hard requirement that these files be named Makefile, then I would request that the kernel documentation be updated to reflect this.
>
> -Mitch
First, upstream kernel does not care how or why you do something for out-of-tree driver.
As far as network developers are concerned, it is your own process (mistake) and you can
live with the consequences of that decision.
Second, why introduce something different to upstream with no apparent benefit
$ find drivers/net -name Kbuild | wc -l
0
next prev parent reply other threads:[~2013-09-06 17:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 6:01 [net-next v5 0/8][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2013-09-06 6:01 ` [net-next v5 1/8] i40e: main driver core Jeff Kirsher
2013-09-06 6:01 ` [net-next v5 2/8] i40e: transmit, receive, and NAPI Jeff Kirsher
2013-09-06 6:01 ` [net-next v5 3/8] i40e: driver ethtool core Jeff Kirsher
2013-09-06 6:01 ` [net-next v5 4/8] i40e: driver core headers Jeff Kirsher
2013-09-06 6:01 ` [net-next v5 5/8] i40e: implement virtual device interface Jeff Kirsher
2013-09-06 6:01 ` [net-next v5 6/8] i40e: init code and hardware support Jeff Kirsher
2013-09-06 6:01 ` [net-next v5 7/8] i40e: debugfs interface Jeff Kirsher
2013-09-06 6:01 ` [net-next v5 8/8] i40e: include i40e in kernel proper Jeff Kirsher
2013-09-06 6:14 ` Stephen Hemminger
2013-09-06 6:28 ` [E1000-devel] " Brandeburg, Jesse
2013-09-06 6:47 ` Joe Perches
2013-09-06 17:28 ` Williams, Mitch A
2013-09-06 17:39 ` Stephen Hemminger [this message]
2013-09-06 18:20 ` Joe Perches
2013-09-06 18:23 ` David Miller
2013-09-06 18:01 ` David Miller
2013-09-06 18:30 ` Jesse Brandeburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130906103905.125c2fa8@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=e1000-devel@lists$(echo .)sourceforge.net \
--cc=gospo@redhat$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=joe@perches$(echo .)com \
--cc=mitch.a.williams@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sassmann@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox