From: Stephen Hemminger <stephen@networkplumber•org>
To: Joseph Gasparakis <joseph.gasparakis@intel•com>
Cc: Daniel Borkmann <dborkman@redhat•com>,
Jeff Kirsher <jeffrey.t.kirsher@intel•com>,
davem@davemloft•net, netdev@vger•kernel.org, gospo@redhat•com,
sassmann@redhat•com, John Fastabend <john.r.fastabend@intel•com>
Subject: Re: [net-next v4] vxlan: Notify drivers for listening UDP port changes
Date: Fri, 6 Sep 2013 16:50:43 -0700 [thread overview]
Message-ID: <20130906165043.1c8a2442@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <alpine.LFD.2.03.1309061629420.21291@intel.com>
On Fri, 6 Sep 2013 16:42:26 -0700 (PDT)
Joseph Gasparakis <joseph.gasparakis@intel•com> wrote:
> That is correct, I started assuming dev will be a valid pointer, but then
> I thought I shouldn't trust the caller, so I ended up with this. In fact I
> have some upcoming sparse fixes too, so I will incorporate all this in one
> patch. For this particular comment I will be checking dev first and
> assigning net and vn after that.
This is the kernel, audit the callers. We don't add random null
pointer checks because that is worse. It creates random error paths
to validate.
next prev parent reply other threads:[~2013-09-06 23:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 9:13 [net-next v4] vxlan: Notify drivers for listening UDP port changes Jeff Kirsher
2013-09-04 9:13 ` [net-next v4 RFC] ixgbe: Get and display the notifications from changes of the Rx vxlan UDP port Jeff Kirsher
2013-10-10 10:07 ` Or Gerlitz
2013-09-05 16:45 ` [net-next v4] vxlan: Notify drivers for listening UDP port changes David Miller
2013-09-06 23:05 ` Daniel Borkmann
2013-09-06 23:42 ` Joseph Gasparakis
2013-09-06 23:50 ` Stephen Hemminger [this message]
2013-09-07 0:09 ` Joseph Gasparakis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130906165043.1c8a2442@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dborkman@redhat$(echo .)com \
--cc=gospo@redhat$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=john.r.fastabend@intel$(echo .)com \
--cc=joseph.gasparakis@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sassmann@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox