Subject: Re: [PATCH] pch_gbe: fix unmet direct dependency on PTP_1588_CLOCK_PCH

From: Vladimir Murzin <[email-masked]>
Date: Tue, 10 Sep 2013 04:29:38 +0200

On Mon, Sep 09, 2013 at 01:00:37PM -0700, Randy Dunlap wrote:
> On 09/09/13 12:28, Vladimir Murzin wrote:
> > While cross-building for PPC.
> > 
> > warning: (PCH_GBE) selects PTP_1588_CLOCK_PCH which has unmet direct
> > dependencies (X86 || COMPILE_TEST)
> > 
> > Both PCH_GBE and PPT_1588_CLOCK_PCH is only compatible with Intel
> > architecture. Add dependency on x86 for PCH_GBE. Keep COMPILE_TEST to allow
> > building on different arches.
> > 
> > Signed-off-by: Vladimir Murzin <[email-masked]>
> > ---
> >  drivers/net/ethernet/oki-semi/pch_gbe/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
> > index cb22341..4a935ec 100644
> > --- a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
> > +++ b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
> > @@ -4,7 +4,7 @@
> >  
> >  config PCH_GBE
> >  	tristate "OKI SEMICONDUCTOR IOH(ML7223/ML7831) GbE"
> > -	depends on PCI
> > +	depends on PCI && (x86 || COMPILE_TEST)
> 
> Has this been tested?
> That should be             X86

Right, it should be X86. It was cross-compile tested which was obviously not
enough. Thanks.

> 
> >  	select MII
> >  	select PTP_1588_CLOCK_PCH
> >  	---help---
> > 
> 
> 
> -- 
> ~Randy