From: Stephen Hemminger <stephen@networkplumber•org>
To: Chris Healy <cphealy@gmail•com>
Cc: "David S. Miller" <davem@davemloft•net>,
bridge@lists•linux-foundation.org, netdev@vger•kernel.org,
buytenh@wantstofly•org
Subject: Re: [PATCH 1/1] bridge: fix message_age_timer calculation
Date: Tue, 10 Sep 2013 11:41:52 -0700 [thread overview]
Message-ID: <20130910114152.40b28ef3@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1378745768-4495-1-git-send-email-cphealy@gmail.com>
On Mon, 9 Sep 2013 09:56:08 -0700
Chris Healy <cphealy@gmail•com> wrote:
> This changes the message_age_timer calculation to use the BPDU's max age as opposed to the local bridge's max age. This is in accordance with section 8.6.2.3.2 Step 2 of the 802.1D-1998 sprecification.
>
> With the current implementation, when running with very large bridge diameters, convergance will not always occur even if a root bridge is configured to have a longer max age.
>
> Tested successfully on bridge diameters of ~200.
>
> Signed-off-by: Chris Healy <cphealy@gmail•com>
> ---
> net/bridge/br_stp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bridge/br_stp.c b/net/bridge/br_stp.c
> index 1c0a50f..f1887ba 100644
> --- a/net/bridge/br_stp.c
> +++ b/net/bridge/br_stp.c
> @@ -209,7 +209,7 @@ static void br_record_config_information(struct net_bridge_port *p,
> p->designated_age = jiffies - bpdu->message_age;
>
> mod_timer(&p->message_age_timer, jiffies
> - + (p->br->max_age - bpdu->message_age));
> + + (bpdu->max_age - bpdu->message_age));
> }
>
> /* called under bridge lock */
This makes sense.
Acked-by: Stephen Hemminger <stephen@networkplumber•org>
next prev parent reply other threads:[~2013-09-10 18:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 16:56 [PATCH 1/1] bridge: fix message_age_timer calculation Chris Healy
2013-09-10 18:41 ` Stephen Hemminger [this message]
2013-09-11 18:40 ` Sergei Shtylyov
2013-09-11 20:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130910114152.40b28ef3@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber$(echo .)org \
--cc=bridge@lists$(echo .)linux-foundation.org \
--cc=buytenh@wantstofly$(echo .)org \
--cc=cphealy@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox