From: Stephen Hemminger <stephen@networkplumber•org>
To: Prarit Bhargava <prarit@redhat•com>
Cc: netdev@vger•kernel.org, jpirko@redhat•com, tgraf@redhat•com,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH] net, vxlan Fix compile warning
Date: Fri, 13 Sep 2013 07:40:10 -0700 [thread overview]
Message-ID: <20130913074010.5a778f79@samsung-9> (raw)
In-Reply-To: <52331FF7.3070905@redhat.com>
On Fri, 13 Sep 2013 10:23:51 -0400
Prarit Bhargava <prarit@redhat•com> wrote:
>
>
> On 09/13/2013 10:20 AM, Stephen Hemminger wrote:
> > On Fri, 13 Sep 2013 08:29:12 -0400
> > Prarit Bhargava <prarit@redhat•com> wrote:
> >
> >> Fix a unintialized variable warning.
> >>
> >> drivers/net/vxlan.c: In function ‘vxlan_sock_add’:
> >> drivers/net/vxlan.c:2240:11: error: ‘sock’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
> >> vs->sock = sock;
> >> ^
> >> drivers/net/vxlan.c:2217:17: note: ‘sock’ was declared here
> >> struct socket *sock;
> >> ^
> >>
> >> Signed-off-by: Prarit Bhargava <prarit@redhat•com>
> >> Cc: jpirko@redhat•com
> >> Cc: tgraf@redhat•com
> >> Cc: "David S. Miller" <davem@davemloft•net>
> >
> > Which compiler version? Gcc 4.6 is known to be stupid,
> > and I would rather not change the source if it is only caused
> > by a gcc bug fixed in a later release.
>
> Hi Stephen,
>
> [root@intel-rosecity-06 ~]# gcc --version
> gcc (GCC) 4.8.1 20130603 (Red Hat 4.8.1-1)
> Copyright (C) 2013 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions. There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
>
> P.
Argh, gcc got stupid again. I guess we have to live it.
Acked-by: Stephen Hemminger <stephen@networkplumber•org>
next prev parent reply other threads:[~2013-09-13 14:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 12:29 [PATCH] net, vxlan Fix compile warning Prarit Bhargava
2013-09-13 12:58 ` Jiri Pirko
2013-09-13 14:20 ` Stephen Hemminger
2013-09-13 14:23 ` Prarit Bhargava
2013-09-13 14:40 ` Stephen Hemminger [this message]
2013-09-17 1:23 ` David Miller
2013-09-17 19:12 ` [PATCH 1/2] " Prarit Bhargava
2013-09-17 20:26 ` Ben Hutchings
2013-09-19 13:04 ` [PATCH 1/2] net, vxlan Fix compile warning [v3] Prarit Bhargava
2013-09-19 13:09 ` David Miller
2013-09-19 13:13 ` Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130913074010.5a778f79@samsung-9 \
--to=stephen@networkplumber$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=jpirko@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=prarit@redhat$(echo .)com \
--cc=tgraf@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox