From: Konrad Rzeszutek Wilk <konrad.wilk@oracle•com>
To: Wei Liu <wei.liu2@citrix•com>
Cc: netdev@vger•kernel.org, Anirban Chakraborty <abchak@juniper•net>,
Ian Campbell <ian.campbell@citrix•com>,
xen-devel@lists•xen.org
Subject: Re: [Xen-devel] [PATCH net-next] xen-netfront: convert to GRO API and advertise this feature
Date: Tue, 24 Sep 2013 12:30:36 -0400 [thread overview]
Message-ID: <20130924163036.GB13979@phenom.dumpdata.com> (raw)
In-Reply-To: <1379779543-27122-1-git-send-email-wei.liu2@citrix.com>
On Sat, Sep 21, 2013 at 05:05:43PM +0100, Wei Liu wrote:
> Anirban was seeing netfront received MTU size packets, which downgraded
> throughput. The following patch makes netfront use GRO API which
> improves throughput for that case.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix•com>
> Signed-off-by: Anirban Chakraborty <abchak@juniper•net>
> Cc: Ian Campbell <ian.campbell@citrix•com>
Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle•com>
> ---
> drivers/net/xen-netfront.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
> index 36808bf..5664165 100644
> --- a/drivers/net/xen-netfront.c
> +++ b/drivers/net/xen-netfront.c
> @@ -952,7 +952,7 @@ static int handle_incoming_queue(struct net_device *dev,
> u64_stats_update_end(&stats->syncp);
>
> /* Pass it up. */
> - netif_receive_skb(skb);
> + napi_gro_receive(&np->napi, skb);
> }
>
> return packets_dropped;
> @@ -1051,6 +1051,8 @@ err:
> if (work_done < budget) {
> int more_to_do = 0;
>
> + napi_gro_flush(napi, false);
> +
> local_irq_save(flags);
>
> RING_FINAL_CHECK_FOR_RESPONSES(&np->rx, more_to_do);
> @@ -1371,7 +1373,8 @@ static struct net_device *xennet_create_dev(struct xenbus_device *dev)
> netif_napi_add(netdev, &np->napi, xennet_poll, 64);
> netdev->features = NETIF_F_IP_CSUM | NETIF_F_RXCSUM |
> NETIF_F_GSO_ROBUST;
> - netdev->hw_features = NETIF_F_IP_CSUM | NETIF_F_SG | NETIF_F_TSO;
> + netdev->hw_features = NETIF_F_IP_CSUM | NETIF_F_SG | NETIF_F_TSO |
> + NETIF_F_GRO;
>
> /*
> * Assume that all hw features are available for now. This set
> --
> 1.7.10.4
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists•xen.org
> http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2013-09-24 16:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-21 16:05 [PATCH net-next] xen-netfront: convert to GRO API and advertise this feature Wei Liu
2013-09-22 6:29 ` [Xen-devel] " Jason Wang
2013-09-22 12:09 ` Wei Liu
2013-09-22 23:04 ` Anirban Chakraborty
2013-09-23 5:02 ` Jason Wang
2013-09-23 6:22 ` annie li
2013-09-23 20:32 ` Anirban Chakraborty
2013-09-22 14:55 ` Eric Dumazet
2013-09-22 23:09 ` Anirban Chakraborty
2013-09-23 5:58 ` Eric Dumazet
2013-09-23 20:27 ` Anirban Chakraborty
2013-09-24 16:30 ` Konrad Rzeszutek Wilk [this message]
2013-09-28 19:38 ` David Miller
2013-09-30 9:12 ` Ian Campbell
2013-09-30 14:43 ` [Xen-devel] " Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130924163036.GB13979@phenom.dumpdata.com \
--to=konrad.wilk@oracle$(echo .)com \
--cc=abchak@juniper$(echo .)net \
--cc=ian.campbell@citrix$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=wei.liu2@citrix$(echo .)com \
--cc=xen-devel@lists$(echo .)xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox