From: "Paul E. McKenney" <paulmck@linux•vnet.ibm.com>
To: Josh Triplett <josh@joshtriplett•org>,
peterz@infradead•org, fweisbec@gmail•com, dhowells@redhat•com,
edumazet@google•com, gaofeng@cn•fujitsu.com, mingo@kernel•org,
bridge@lists•linux-foundation.org, jmorris@namei•org,
dipankar@in•ibm.com, darren@dvhart•com, rostedt@goodmis•org,
niv@us•ibm.com, mathieu.desnoyers@efficios•com,
kuznet@ms2•inr.ac.ru, tglx@linutronix•de,
johannes@sipsolutions•net, laijs@cn•fujitsu.com,
yoshfuji@linux-ipv6•org, netdev@vger•kernel.org,
linux-decnet-user@lists•sourceforge.net,
linux-kernel@vger•kernel.org, kaber@trash•net,
stephen@networkplumber•org, sbw@mit•edu, tgraf@suug•ch,
akpm@linux-foundation•org, fengguang.wu@intel•com,
davem@davemloft•net
Subject: Re: [PATCH v3 tip/core/rcu 0/14] Sparse-related updates for 3.13
Date: Sun, 13 Oct 2013 04:17:16 -0700 [thread overview]
Message-ID: <20131013111716.GG5790@linux.vnet.ibm.com> (raw)
In-Reply-To: <20131012174354.GE20321@order.stressinduktion.org>
On Sat, Oct 12, 2013 at 07:43:54PM +0200, Hannes Frederic Sowa wrote:
> On Sat, Oct 12, 2013 at 07:39:30PM +0200, Hannes Frederic Sowa wrote:
> > On Sat, Oct 12, 2013 at 10:13:45AM -0700, Paul E. McKenney wrote:
> > > On Fri, Oct 11, 2013 at 11:53:27PM -0700, Josh Triplett wrote:
> > > > On Fri, Oct 11, 2013 at 04:16:59PM -0700, Paul E. McKenney wrote:
> > > > > Changes from v2:
> > > > >
> > > > > o Switch from rcu_assign_pointer() to ACCESS_ONCE() given that
> > > > > the pointers are all --rcu and already visible to readers,
> > > > > as suggested by Eric Dumazet and Josh Triplett.
> > > >
> > > > Hang on a moment. Do *none* of these cases need write memory barriers?
> > >
> > > Sigh. Some afternoons it doesn't pay to touch the keyboard.
> > >
> > > Thank you for catching this. I will fix, but at this point, I am thinking
> > > in terms of 3.14 rather than 3.13 for this series.
> >
> > Some of them looked safe. You could also replace --rcu with __rcu in the
> > comments while at it.
>
> Most of them deal with management, maybe a rtnl_assign_pointer with lockdep
> check for rtnl lock could help to not clean up the wrong bits.
>
> I don't know if rtnl_assign_pointer is that a could name as it does not really
> explain why the barrier is not needed there. :/
Beyond a certain point, I need to let people who know more about Linux's
networking implementation handle this sort of thing.
Thanx, Paul
next prev parent reply other threads:[~2013-10-13 11:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 23:16 [PATCH v3 tip/core/rcu 0/14] Sparse-related updates for 3.13 Paul E. McKenney
[not found] ` <1381533451-29018-1-git-send-email-paulmck@linux.vnet.ibm.com>
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 03/14] bridge: Apply ACCESS_ONCE() to avoid sparse false positive Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 04/14] wireless: " Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 05/14] decnet: " Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 06/14] ipv4/ip_socketglue: " Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 07/14] ipv6/ip6_tunnel: " Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 08/14] ipv6/ip6_gre: " Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 09/14] ipv6/sit: " Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 10/14] mac80211: " Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 11/14] bridge/br_mdb: " Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 12/14] bonding/bond_main: " Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 13/14] bonding/bond_alb.c: " Paul E. McKenney
2013-10-12 6:53 ` [PATCH v3 tip/core/rcu 0/14] Sparse-related updates for 3.13 Josh Triplett
2013-10-12 17:13 ` Paul E. McKenney
2013-10-12 17:39 ` [Bridge] " Hannes Frederic Sowa
2013-10-12 17:43 ` Hannes Frederic Sowa
2013-10-13 11:17 ` Paul E. McKenney [this message]
2013-10-13 11:15 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131013111716.GG5790@linux.vnet.ibm.com \
--to=paulmck@linux$(echo .)vnet.ibm.com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=bridge@lists$(echo .)linux-foundation.org \
--cc=darren@dvhart$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dhowells@redhat$(echo .)com \
--cc=dipankar@in$(echo .)ibm.com \
--cc=edumazet@google$(echo .)com \
--cc=fengguang.wu@intel$(echo .)com \
--cc=fweisbec@gmail$(echo .)com \
--cc=gaofeng@cn$(echo .)fujitsu.com \
--cc=jmorris@namei$(echo .)org \
--cc=johannes@sipsolutions$(echo .)net \
--cc=josh@joshtriplett$(echo .)org \
--cc=kaber@trash$(echo .)net \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=laijs@cn$(echo .)fujitsu.com \
--cc=linux-decnet-user@lists$(echo .)sourceforge.net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mathieu.desnoyers@efficios$(echo .)com \
--cc=mingo@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=niv@us$(echo .)ibm.com \
--cc=peterz@infradead$(echo .)org \
--cc=rostedt@goodmis$(echo .)org \
--cc=sbw@mit$(echo .)edu \
--cc=stephen@networkplumber$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=tgraf@suug$(echo .)ch \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox