public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Greg KH <gregkh@linuxfoundation•org>
To: "Sebastian Pöhn" <sebastian.poehn@gmail•com>
Cc: support@caviumnetworks•com, netdev@vger•kernel.org,
	driverdev-devel@linuxdriverproject•org
Subject: Re: [PATCH] staging: octeon-ethernet: trivial: Avoid OOPS if phydev is not set
Date: Sun, 13 Oct 2013 14:28:10 -0700	[thread overview]
Message-ID: <20131013212810.GA15167@kroah.com> (raw)
In-Reply-To: <1381690794.2848.11.camel@alpha.Speedport_W723_V_Typ_A_1_00_098>

On Sun, Oct 13, 2013 at 08:59:54PM +0200, Sebastian Pöhn wrote:
> A zero pointer deref on priv->phydev->link was causing oops on our systems.
> Might be related to improper configuration but we should fail gracefully here ;-)
> 
> Signed-off-by: Sebastian Poehn <sebastian.poehn@googlemail•com>
> 
> ---
> 
> diff --git a/drivers/staging/octeon/ethernet-mdio.c b/drivers/staging/octeon/ethernet-mdio.c
> index 83b1030..bc8c503 100644
> --- a/drivers/staging/octeon/ethernet-mdio.c
> +++ b/drivers/staging/octeon/ethernet-mdio.c
> @@ -121,6 +121,9 @@ static void cvm_oct_adjust_link(struct net_device *dev)
>         struct octeon_ethernet *priv = netdev_priv(dev);
>         cvmx_helper_link_info_t link_info;
>  
> +       if(!priv->phydev)
> +               return ;

Please always run your patches through the scripts/checkpatch.pl tool so
that maintainers don't have to point out the obvious coding syle errors
by hand each time :)

Care to try again?

Also, how was phydev NULL?  What was causing that?

thanks,

greg k-h

next prev parent reply	other threads:[~2013-10-13 21:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-13 18:59 [PATCH] staging: octeon-ethernet: trivial: Avoid OOPS if phydev is not set Sebastian Pöhn
2013-10-13 21:28 ` Greg KH [this message]
2013-10-14 10:10   ` Dan Carpenter
2013-10-14 18:39     ` Aaro Koskinen
2013-10-14 19:16       ` Dan Carpenter
2013-10-14 19:49         ` Aaro Koskinen
2013-10-15  9:47           ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131013212810.GA15167@kroah.com \
    --to=gregkh@linuxfoundation$(echo .)org \
    --cc=driverdev-devel@linuxdriverproject$(echo .)org \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=sebastian.poehn@gmail$(echo .)com \
    --cc=support@caviumnetworks$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox