Subject: Re: [PATCH 01/07] 8139too: Support for byte queue limits

From: Tino Reichardt <[email-masked]>
Date: Mon, 14 Oct 2013 21:52:01 +0200

* Eric Dumazet <[email-masked]> wrote:
> On Mon, 2013-10-14 at 20:26 +0200, Tino Reichardt wrote:
> > Changes to 8139too to use byte queue limits.
> > 
> > @@ -1733,6 +1735,7 @@ static netdev_tx_t rtl8139_start_xmit (struct sk_buff *skb,
> >  		   tp->tx_flag | max(len, (unsigned int)ETH_ZLEN));
> >  
> >  	tp->cur_tx++;
> > +	netdev_sent_queue(dev, len);
> >  
> 
> This looks wrong if len < ETH_ZLEN

Fixed this (really stupid) issue, updated patch is located here:
 http://www.mcmilk.de/projects/linux-bql/dl/0001-8139too-Support-for-byte-queue-limits.patch

The netif_dbg() statement will now also print the correct queued length.

-- 
Best regards, TR