Subject: Re: [PATCH v2 net 1/4] bridge: Don't use VID 0 and 4095 in vlan filtering

From: Stephen Hemminger <[email-masked]>
Date: Wed, 16 Oct 2013 08:47:38 -0700

On Wed, 16 Oct 2013 17:07:13 +0900
Toshiaki Makita <[email-masked]> wrote:

> IEEE 802.1Q says that:
> - VID 0 shall not be configured as a PVID, or configured in any Filtering
> Database entry.
> - VID 4095 shall not be configured as a PVID, or transmitted in a tag
> header. This VID value may be used to indicate a wildcard match for the VID
> in management operations or Filtering Database entries.
> (See IEEE 802.1Q-2011 6.9.1 and Table 9-2)
> 
> Don't accept adding these VIDs in the vlan_filtering implementation.
> 
> Signed-off-by: Toshiaki Makita <[email-masked]>
> Reviewed-by: Vlad Yasevich <[email-masked]>
> ---
>  net/bridge/br_fdb.c     |  4 +-
>  net/bridge/br_netlink.c |  2 +-
>  net/bridge/br_vlan.c    | 97 +++++++++++++++++++++++--------------------------
>  3 files changed, 49 insertions(+), 54 deletions(-)

This one looks good, thanks.

Acked-by: Stephen Hemminger <[email-masked]>